From 696435cdcc397ba3a3806f8a1e488d0be2b750ac Mon Sep 17 00:00:00 2001 From: Shuduo Sang Date: Sun, 11 Jul 2021 21:51:07 +0800 Subject: [PATCH] Hotfix/sangshuduo/td 3801 taosdump coverity scan issue for develop (#6831) * fix converity scan issue. * fix converity issues * fix converity scan issue. Co-authored-by: Shuduo Sang --- src/kit/taosdump/taosdump.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/kit/taosdump/taosdump.c b/src/kit/taosdump/taosdump.c index e6820f396b..98521d8420 100644 --- a/src/kit/taosdump/taosdump.c +++ b/src/kit/taosdump/taosdump.c @@ -124,6 +124,9 @@ typedef struct { extern char version[]; +#define DB_PRECISION_LEN 8 +#define DB_STATUS_LEN 16 + typedef struct { char name[TSDB_DB_NAME_LEN]; char create_time[32]; @@ -144,9 +147,9 @@ typedef struct { int32_t fsync; int8_t comp; int8_t cachelast; - char precision[8]; // time resolution + char precision[DB_PRECISION_LEN]; // time resolution int8_t update; - char status[16]; + char status[DB_STATUS_LEN]; } SDbInfo; typedef struct { @@ -542,7 +545,8 @@ static void parse_precision_first( free(tmp); exit(-1); } - strncpy(g_args.precision, tmp, strlen(tmp)); + strncpy(g_args.precision, tmp, + min(DB_PRECISION_LEN - 1, strlen(tmp))); free(tmp); } } -- GitLab