From 5405a967fb70a083ee8ebd576b086b17f011e729 Mon Sep 17 00:00:00 2001
From: Hongze Cheng <hzcheng@taosdata.com>
Date: Mon, 12 Jun 2023 13:39:25 +0800
Subject: [PATCH] refact code

---
 .../dnode/vnode/src/tsdb/dev/inc/tsdbIter.h   | 11 ++++++-----
 source/dnode/vnode/src/tsdb/dev/tsdbCommit.c  |  2 +-
 source/dnode/vnode/src/tsdb/dev/tsdbIter.c    | 19 +++++++++++++++----
 source/dnode/vnode/src/tsdb/dev/tsdbMerge.c   |  4 ++--
 4 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/source/dnode/vnode/src/tsdb/dev/inc/tsdbIter.h b/source/dnode/vnode/src/tsdb/dev/inc/tsdbIter.h
index ed46bfe884..41f0c76ade 100644
--- a/source/dnode/vnode/src/tsdb/dev/inc/tsdbIter.h
+++ b/source/dnode/vnode/src/tsdb/dev/inc/tsdbIter.h
@@ -55,12 +55,13 @@ int32_t tsdbIterClose(STsdbIter **iter);
 int32_t tsdbIterNext(STsdbIter *iter);
 
 // SIterMerger ===============
-int32_t      tsdbIterMergerOpen(const TTsdbIterArray *iterArray, SIterMerger **merger, bool isTomb);
-int32_t      tsdbIterMergerClose(SIterMerger **merger);
-int32_t      tsdbIterMergerNext(SIterMerger *merger);
-SRowInfo    *tsdbIterMergerGet(SIterMerger *merger);
+int32_t tsdbIterMergerOpen(const TTsdbIterArray *iterArray, SIterMerger **merger, bool isTomb);
+int32_t tsdbIterMergerClose(SIterMerger **merger);
+int32_t tsdbIterMergerNext(SIterMerger *merger);
+int32_t tsdbIterMergerSkipTableData(SIterMerger *merger, const TABLEID *tbid);
+
+SRowInfo    *tsdbIterMergerGetData(SIterMerger *merger);
 STombRecord *tsdbIterMergerGetTombRecord(SIterMerger *merger);
-int32_t      tsdbIterMergerSkipTableData(SIterMerger *merger, const TABLEID *tbid);
 
 #ifdef __cplusplus
 }
diff --git a/source/dnode/vnode/src/tsdb/dev/tsdbCommit.c b/source/dnode/vnode/src/tsdb/dev/tsdbCommit.c
index 6a43f13d01..9c7d05138e 100644
--- a/source/dnode/vnode/src/tsdb/dev/tsdbCommit.c
+++ b/source/dnode/vnode/src/tsdb/dev/tsdbCommit.c
@@ -178,7 +178,7 @@ static int32_t tsdbCommitTSData(SCommitter2 *committer) {
   TSDB_CHECK_CODE(code, lino, _exit);
 
   // loop iter
-  while ((row = tsdbIterMergerGet(committer->iterMerger)) != NULL) {
+  while ((row = tsdbIterMergerGetData(committer->iterMerger)) != NULL) {
     if (row->uid != committer->ctx->tbid->uid) {
       committer->ctx->tbid->suid = row->suid;
       committer->ctx->tbid->uid = row->uid;
diff --git a/source/dnode/vnode/src/tsdb/dev/tsdbIter.c b/source/dnode/vnode/src/tsdb/dev/tsdbIter.c
index f0078f93f0..6b614d7e84 100644
--- a/source/dnode/vnode/src/tsdb/dev/tsdbIter.c
+++ b/source/dnode/vnode/src/tsdb/dev/tsdbIter.c
@@ -544,6 +544,7 @@ static int32_t tsdbTombIterCmprFn(const SRBTreeNode *n1, const SRBTreeNode *n2)
 
 // SIterMerger ================
 struct SIterMerger {
+  bool       isTomb;
   STsdbIter *iter;
   SRBTree    iterTree[1];
 };
@@ -553,8 +554,11 @@ int32_t tsdbIterMergerOpen(const TTsdbIterArray *iterArray, SIterMerger **merger
   SRBTreeNode *node;
 
   merger[0] = taosMemoryCalloc(1, sizeof(*merger[0]));
-  if (!merger[0]) return TSDB_CODE_OUT_OF_MEMORY;
+  if (merger[0] == NULL) {
+    return TSDB_CODE_OUT_OF_MEMORY;
+  }
 
+  merger[0]->isTomb = isTomb;
   if (isTomb) {
     tRBTreeCreate(merger[0]->iterTree, tsdbTombIterCmprFn);
   } else {
@@ -599,15 +603,22 @@ int32_t tsdbIterMergerNext(SIterMerger *merger) {
     }
   }
 
-  if (!merger->iter && (node = tRBTreeDropMin(merger->iterTree))) {
+  if (merger->iter == NULL && (node = tRBTreeDropMin(merger->iterTree))) {
     merger->iter = TCONTAINER_OF(node, STsdbIter, node);
   }
 
   return 0;
 }
 
-SRowInfo    *tsdbIterMergerGet(SIterMerger *merger) { return merger->iter ? merger->iter->row : NULL; }
-STombRecord *tsdbIterMergerGetTombRecord(SIterMerger *merger) { return merger->iter ? merger->iter->record : NULL; }
+SRowInfo *tsdbIterMergerGetData(SIterMerger *merger) {
+  ASSERT(!merger->isTomb);
+  return merger->iter ? merger->iter->row : NULL;
+}
+
+STombRecord *tsdbIterMergerGetTombRecord(SIterMerger *merger) {
+  ASSERT(merger->isTomb);
+  return merger->iter ? merger->iter->record : NULL;
+}
 
 int32_t tsdbIterMergerSkipTableData(SIterMerger *merger, const TABLEID *tbid) {
   int32_t      code;
diff --git a/source/dnode/vnode/src/tsdb/dev/tsdbMerge.c b/source/dnode/vnode/src/tsdb/dev/tsdbMerge.c
index 3f45301efe..eb4fb18ddd 100644
--- a/source/dnode/vnode/src/tsdb/dev/tsdbMerge.c
+++ b/source/dnode/vnode/src/tsdb/dev/tsdbMerge.c
@@ -199,7 +199,7 @@ static int32_t tsdbMergeToDataLevel(SMerger *merger) {
   int32_t lino = 0;
 
   // data
-  for (SRowInfo *row; (row = tsdbIterMergerGet(merger->dataIterMerger)) != NULL;) {
+  for (SRowInfo *row; (row = tsdbIterMergerGetData(merger->dataIterMerger)) != NULL;) {
     if (row->uid != merger->ctx->tbid->uid) {
       code = tsdbMergeToDataTableEnd(merger);
       TSDB_CHECK_CODE(code, lino, _exit);
@@ -273,7 +273,7 @@ static int32_t tsdbMergeToUpperLevel(SMerger *merger) {
 
   // data
   SRowInfo *row;
-  while ((row = tsdbIterMergerGet(merger->dataIterMerger))) {
+  while ((row = tsdbIterMergerGetData(merger->dataIterMerger))) {
     code = tsdbSttFileWriteRow(merger->sttWriter, row);
     TSDB_CHECK_CODE(code, lino, _exit);
 
-- 
GitLab