Merge pull request #11877 from taosdata/fix/TD-14916

fix: coredump if mode function with interval

src/client/src/tscSQLParser.c

@@ -3362,14 +3362,8 @@ int32_t addExprAndResultField(SSqlCmd* pCmd, SQueryInfo* pQueryInfo, int32_t col
         tVariantDump(pVariant, val, TSDB_DATA_TYPE_BIGINT, true);
 
         if(functionId == TSDB_FUNC_UNIQUE){   // consider of memory size
-          if(pSchema->bytes < 10){
-            GET_INT64_VAL(val) = MAX_UNIQUE_RESULT_ROWS * 100;
-          }else if(pSchema->bytes < 100){
-            GET_INT64_VAL(val) = MAX_UNIQUE_RESULT_ROWS * 10;
-          }else{
           GET_INT64_VAL(val) = MAX_UNIQUE_RESULT_ROWS;
         }
-        }
 
         int64_t numRowsSelected = GET_INT64_VAL(val);
         if (functionId != TSDB_FUNC_UNIQUE && (numRowsSelected <= 0 || numRowsSelected > 100)) {  // todo use macro

src/client/src/tscUtil.c

@@ -1528,6 +1528,11 @@ void handleDownstreamOperator(SSqlObj** pSqlObjList, int32_t numOfUpstream, SQue
 
     tscDebug("0x%"PRIx64" create QInfo 0x%"PRIx64" to execute the main query while all nest queries are ready", pSql->self, pSql->self);
     px->pQInfo = createQInfoFromQueryNode(px, &tableGroupInfo, pSourceOperator, NULL, NULL, MASTER_SCAN, pSql->self);
+    if (px->pQInfo == NULL) {
+      tscAsyncResultOnError(pSql);
+      pOutput->code = TSDB_CODE_QRY_OUT_OF_MEMORY;
+      return;
+    }
 
     px->pQInfo->runtimeEnv.udfIsCopy = true;
     px->pQInfo->runtimeEnv.pUdfInfo = pUdfInfo;

src/query/inc/qResultbuf.h

@@ -79,9 +79,9 @@ typedef struct SDiskbasedResultBuf {
 #define DEFAULT_INTERN_BUF_PAGE_SIZE  (1024L)                          // in bytes
 #define PAGE_INFO_INITIALIZER         (SPageDiskInfo){-1, -1}
 #define MAX_UNIQUE_RESULT_ROWS (10000)
-#define MAX_UNIQUE_RESULT_SIZE (1024*1024*10)
-#define MAX_MODE_INNER_RESULT_ROWS (1000000)
-#define MAX_MODE_INNER_RESULT_SIZE (1024*1024*10)
+#define MAX_UNIQUE_RESULT_SIZE (1024*1024)
+#define MAX_MODE_INNER_RESULT_ROWS (10000)
+#define MAX_MODE_INNER_RESULT_SIZE (1024*1024)
 /**
  * create disk-based result buffer
  * @param pResultBuf

src/query/src/qExecutor.c

@@ -330,11 +330,11 @@ SSDataBlock* createOutputBuf(SExprInfo* pExpr, int32_t numOfOutput, int32_t numO
 
     int64_t tmp = idata.info.bytes;
     tmp *= numOfRows;
-    if (tmp >= 1024*1024*1024) {   // 1G
-      qError("size is too large, failed to allocate column buffer for output buffer");
+    if (tmp >= INT32_MAX) {
+      qError("size is too large, failed to allocate column buffer for output buffer:%" PRId64, tmp);
       tmp = 128*1024*1024;
     }
-    int32_t size = (int32_t)MAX(tmp, minSize);
+    size_t size = (size_t)MAX(tmp, minSize);
     idata.pData = calloc(1, size);  // at least to hold a pointer on x64 platform
     if (idata.pData == NULL) {
       qError("failed to allocate column buffer for output buffer");
@@ -2131,7 +2131,7 @@ static int32_t setupQueryRuntimeEnv(SQueryRuntimeEnv *pRuntimeEnv, int32_t numOf
   pRuntimeEnv->sasArray = calloc(pQueryAttr->numOfOutput, sizeof(SScalarExprSupport));
 
   if (pRuntimeEnv->sasArray == NULL || pRuntimeEnv->pResultRowHashTable == NULL || pRuntimeEnv->keyBuf == NULL ||
-      pRuntimeEnv->prevRow == NULL  || pRuntimeEnv->tagVal == NULL) {
+      pRuntimeEnv->prevRow == NULL  || pRuntimeEnv->tagVal == NULL || pRuntimeEnv->pool == NULL) {
     goto _clean;
   }
 

src/query/src/qUtil.c

@@ -204,9 +204,9 @@ SResultRowPool* initResultRowPool(size_t size) {
   p->elemSize = (int32_t) size;
   int64_t tmp = p->elemSize;
   tmp *= p->numOfElemPerBlock;
-  if (tmp > 1024*1024*1024){
+  if (tmp > INT32_MAX){
     qError("ResultRow blockSize is too large:%" PRId64, tmp);
-    tmp = 128*1024*1024;
+    return NULL;
   }
   p->blockSize = (int32_t)tmp;
   p->position.pos = 0;
@@ -223,6 +223,7 @@ SResultRow* getNewResultRow(SResultRowPool* p) {
   void* ptr = NULL;
   if (p->position.pos == 0) {
     ptr = calloc(1, p->blockSize);
+    if(ptr == NULL) return NULL;
     taosArrayPush(p->pData, &ptr);
 
   } else {