From 399d240df593b1b50ea7ad813823997c9f1d83fa Mon Sep 17 00:00:00 2001
From: yihaoDeng <luomoxyz@126.com>
Date: Wed, 10 Aug 2022 15:41:12 +0800
Subject: [PATCH] refactor index

---
 source/libs/index/src/index.c      | 1 -
 source/libs/index/src/indexCache.c | 3 +--
 source/libs/index/src/indexUtil.c  | 3 ++-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/source/libs/index/src/index.c b/source/libs/index/src/index.c
index d61cd871ee..850ddd4970 100644
--- a/source/libs/index/src/index.c
+++ b/source/libs/index/src/index.c
@@ -485,7 +485,6 @@ static void idxMayMergeTempToFinalRslt(SArray* result, TFileValue* tfv, SIdxTRsl
       // handle last iterator
       idxTRsltMergeTo(tr, lv->tableId);
     } else {
-      // temp result saved in help
       tfileValueDestroy(tfv);
     }
   } else {
diff --git a/source/libs/index/src/indexCache.c b/source/libs/index/src/indexCache.c
index 50745cd3fb..794b85d244 100644
--- a/source/libs/index/src/indexCache.c
+++ b/source/libs/index/src/indexCache.c
@@ -45,7 +45,7 @@ static int32_t cacheSearchLessEqual(void* cache, SIndexTerm* ct, SIdxTRslt* tr,
 static int32_t cacheSearchGreaterThan(void* cache, SIndexTerm* ct, SIdxTRslt* tr, STermValueType* s);
 static int32_t cacheSearchGreaterEqual(void* cache, SIndexTerm* ct, SIdxTRslt* tr, STermValueType* s);
 static int32_t cacheSearchRange(void* cache, SIndexTerm* ct, SIdxTRslt* tr, STermValueType* s);
-/*comm func of compare, used in (LE/LT/GE/GT compare)*/
+/*comm compare func, used in (LE/LT/GE/GT compare)*/
 static int32_t cacheSearchCompareFunc(void* cache, SIndexTerm* ct, SIdxTRslt* tr, STermValueType* s, RangeType type);
 static int32_t cacheSearchTerm_JSON(void* cache, SIndexTerm* ct, SIdxTRslt* tr, STermValueType* s);
 static int32_t cacheSearchEqual_JSON(void* cache, SIndexTerm* ct, SIdxTRslt* tr, STermValueType* s);
@@ -94,7 +94,6 @@ static int32_t cacheSearchTerm(void* cache, SIndexTerm* term, SIdxTRslt* tr, STe
     if (0 == strcmp(c->colVal, pCt->colVal) && strlen(pCt->colVal) == strlen(c->colVal)) {
       if (c->operaType == ADD_VALUE) {
         INDEX_MERGE_ADD_DEL(tr->del, tr->add, c->uid)
-        // taosArrayPush(result, &c->uid);
         *s = kTypeValue;
       } else if (c->operaType == DEL_VALUE) {
         INDEX_MERGE_ADD_DEL(tr->add, tr->del, c->uid)
diff --git a/source/libs/index/src/indexUtil.c b/source/libs/index/src/indexUtil.c
index 1d20278895..3d083c1817 100644
--- a/source/libs/index/src/indexUtil.c
+++ b/source/libs/index/src/indexUtil.c
@@ -152,7 +152,7 @@ int verdataCompare(const void *a, const void *b) {
 
   int32_t cmp = compareUint64Val(&va->data, &vb->data);
   if (cmp == 0) {
-    cmp = 0 - compareUint32Val(&va->ver, &vb->data);
+    cmp = 0 - compareUint32Val(&va->ver, &vb->ver);
     return cmp;
   }
   return cmp;
@@ -181,6 +181,7 @@ void idxTRsltDestroy(SIdxTRslt *tr) {
   taosArrayDestroy(tr->total);
   taosArrayDestroy(tr->add);
   taosArrayDestroy(tr->del);
+  taosMemoryFree(tr);
 }
 void idxTRsltMergeTo(SIdxTRslt *tr, SArray *result) {
   taosArraySort(tr->total, uidCompare);
-- 
GitLab