Merge pull request #17514 from taosdata/fix/TD-19601

fix(query): fix crash if block SMA is set and real data is not loaded.

source/libs/function/src/builtinsimpl.c

@@ -1163,13 +1163,13 @@ static int32_t findRowIndex(int32_t start, int32_t num, SColumnInfoData* pCol, c
   // the data is loaded, not only the block SMA value
   for (int32_t i = start; i < num + start; ++i) {
     char* p = colDataGetData(pCol, i);
-    if (memcpy((void*)tval, p, pCol->info.bytes) == 0) {
+    if (memcmp((void*)tval, p, pCol->info.bytes) == 0) {
       return i;
     }
   }
 
-  ASSERT(0);
-  return 0;
+  // if reach here means real data of block SMA is not set in pCtx->input.
+  return -1;
 }
 
 int32_t doMinMaxHelper(SqlFunctionCtx* pCtx, int32_t isMinFunc) {
@@ -1211,8 +1211,10 @@ int32_t doMinMaxHelper(SqlFunctionCtx* pCtx, int32_t isMinFunc) {
       pBuf->v = *(int64_t*)tval;
       if (pCtx->subsidiaries.num > 0) {
         index = findRowIndex(pInput->startRowIndex, pInput->numOfRows, pCol, tval);
+        if (index >= 0) {
           pBuf->tuplePos = saveTupleData(pCtx, index, pCtx->pSrcBlock, NULL);
         }
+      }
     } else {
       if (IS_SIGNED_NUMERIC_TYPE(type)) {
         int64_t prev = 0;
@@ -1223,9 +1225,11 @@ int32_t doMinMaxHelper(SqlFunctionCtx* pCtx, int32_t isMinFunc) {
           *(int64_t*)&pBuf->v = val;
           if (pCtx->subsidiaries.num > 0) {
             index = findRowIndex(pInput->startRowIndex, pInput->numOfRows, pCol, tval);
+            if (index >= 0) {
               pBuf->tuplePos = saveTupleData(pCtx, index, pCtx->pSrcBlock, NULL);
             }
           }
+        }
       } else if (IS_UNSIGNED_NUMERIC_TYPE(type)) {
         uint64_t prev = 0;
         GET_TYPED_DATA(prev, uint64_t, type, &pBuf->v);
@@ -1235,9 +1239,11 @@ int32_t doMinMaxHelper(SqlFunctionCtx* pCtx, int32_t isMinFunc) {
           *(uint64_t*)&pBuf->v = val;
           if (pCtx->subsidiaries.num > 0) {
             index = findRowIndex(pInput->startRowIndex, pInput->numOfRows, pCol, tval);
+            if (index >= 0) {
               pBuf->tuplePos = saveTupleData(pCtx, index, pCtx->pSrcBlock, NULL);
             }
           }
+        }
       } else if (type == TSDB_DATA_TYPE_DOUBLE) {
         double prev = 0;
         GET_TYPED_DATA(prev, double, type, &pBuf->v);
@@ -1247,9 +1253,11 @@ int32_t doMinMaxHelper(SqlFunctionCtx* pCtx, int32_t isMinFunc) {
           *(double*)&pBuf->v = val;
           if (pCtx->subsidiaries.num > 0) {
             index = findRowIndex(pInput->startRowIndex, pInput->numOfRows, pCol, tval);
+            if (index >= 0) {
               pBuf->tuplePos = saveTupleData(pCtx, index, pCtx->pSrcBlock, NULL);
             }
           }
+        }
       } else if (type == TSDB_DATA_TYPE_FLOAT) {
         float prev = 0;
         GET_TYPED_DATA(prev, float, type, &pBuf->v);
@@ -1261,10 +1269,12 @@ int32_t doMinMaxHelper(SqlFunctionCtx* pCtx, int32_t isMinFunc) {
 
         if (pCtx->subsidiaries.num > 0) {
           index = findRowIndex(pInput->startRowIndex, pInput->numOfRows, pCol, tval);
+          if (index >= 0) {
             pBuf->tuplePos = saveTupleData(pCtx, index, pCtx->pSrcBlock, NULL);
           }
         }
       }
+    }
 
     pBuf->assign = true;
     return numOfElems;