From 2b06d8328c711fdb537ac2bff21310b426311afb Mon Sep 17 00:00:00 2001
From: Cary Xu <klxu@taosdata.com>
Date: Wed, 3 Aug 2022 16:27:50 +0800
Subject: [PATCH] enh: row end optimization

---
 include/common/trow.h    | 7 ++++++-
 source/common/src/trow.c | 8 --------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/include/common/trow.h b/include/common/trow.h
index f2f68ddccd..35270341ff 100644
--- a/include/common/trow.h
+++ b/include/common/trow.h
@@ -290,7 +290,12 @@ int32_t tdSRowSetTpInfo(SRowBuilder *pBuilder, int32_t nCols, int32_t flen);
 int32_t tdSRowSetExtendedInfo(SRowBuilder *pBuilder, int32_t nCols, int32_t nBoundCols, int32_t flen,
                               int32_t allNullLen, int32_t boundNullLen);
 int32_t tdSRowResetBuf(SRowBuilder *pBuilder, void *pBuf);
-int32_t tdSRowEnd(SRowBuilder *pBuilder);
+static FORCE_INLINE void tdSRowEnd(SRowBuilder *pBuilder) {
+  STSRow *pRow = (STSRow *)pBuilder->pBuf;
+  if (pBuilder->nNone || pBuilder->nNull) {
+    pRow->statis = 1;
+  }
+}
 int32_t tdSRowGetBuf(SRowBuilder *pBuilder, void *pBuf);
 void    tdSRowReset(SRowBuilder *pBuilder);
 int32_t tdAppendColValToTpRow(SRowBuilder *pBuilder, TDRowValT valType, const void *val, bool isCopyVarData,
diff --git a/source/common/src/trow.c b/source/common/src/trow.c
index b54d653df9..ec51d65cdd 100644
--- a/source/common/src/trow.c
+++ b/source/common/src/trow.c
@@ -1094,14 +1094,6 @@ int32_t tdSRowSetExtendedInfo(SRowBuilder *pBuilder, int32_t nCols, int32_t nBou
   return TSDB_CODE_SUCCESS;
 }
 
-int32_t tdSRowEnd(SRowBuilder *pBuilder) {
-  STSRow *pRow = (STSRow *)pBuilder->pBuf;
-  if (pBuilder->nNone || pBuilder->nNull) {
-    pRow->statis = 1;
-  }
-  return TSDB_CODE_SUCCESS;
-}
-
 int32_t tdSRowResetBuf(SRowBuilder *pBuilder, void *pBuf) {
   pBuilder->pBuf = (STSRow *)pBuf;
   if (!pBuilder->pBuf) {
-- 
GitLab