From 2a42fc66bc87803cabdb5a96df5f6aeb7cc7e0f9 Mon Sep 17 00:00:00 2001
From: slzhou <slzhou@taosdata.com>
Date: Sat, 14 May 2022 16:51:16 +0800
Subject: [PATCH] fix: udf task to queue whenever uv_write result

---
 source/libs/function/src/tudf.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/source/libs/function/src/tudf.c b/source/libs/function/src/tudf.c
index dd5bee208b..3a388d1c07 100644
--- a/source/libs/function/src/tudf.c
+++ b/source/libs/function/src/tudf.c
@@ -1072,7 +1072,6 @@ int32_t udfcQueueUvTask(SClientUvTaskNode *uvTask) {
 
 int32_t udfcStartUvTask(SClientUvTaskNode *uvTask) {
   fnTrace("event loop start uv task. task: %d, %p", uvTask->type, uvTask);
-  int32_t code = 0;
   switch (uvTask->type) {
     case UV_TASK_CONNECT: {
       uv_pipe_t *pipe = taosMemoryMalloc(sizeof(uv_pipe_t));
@@ -1092,7 +1091,6 @@ int32_t udfcStartUvTask(SClientUvTaskNode *uvTask) {
       uv_connect_t *connReq = taosMemoryMalloc(sizeof(uv_connect_t));
       connReq->data = uvTask;
       uv_pipe_connect(connReq, pipe, uvTask->udfc->udfdPipeName, onUdfcPipeConnect);
-      code = 0;
       break;
     }
     case UV_TASK_REQ_RSP: {
@@ -1103,14 +1101,12 @@ int32_t udfcStartUvTask(SClientUvTaskNode *uvTask) {
       if (err != 0) {
         fnError("udfc event loop start req/rsp task uv_write failed. code: %s", uv_strerror(err));
       }
-      code = err;
       break;
     }
     case UV_TASK_DISCONNECT: {
       SClientUvConn *conn = uvTask->pipe->data;
       QUEUE_INSERT_TAIL(&conn->taskQueue, &uvTask->connTaskQueue);
       uv_close((uv_handle_t *) uvTask->pipe, onUdfcPipeClose);
-      code = 0;
       break;
     }
     default: {
@@ -1119,7 +1115,7 @@ int32_t udfcStartUvTask(SClientUvTaskNode *uvTask) {
     }
   }
 
-  return code;
+  return 0;
 }
 
 void udfClientAsyncCb(uv_async_t *async) {
-- 
GitLab