From 259c076f5a5e64ce044c684d92179b9e5cd47298 Mon Sep 17 00:00:00 2001
From: Ganlin Zhao <ganlinzhao@hotmail.com>
Date: Tue, 7 Sep 2021 23:07:24 +0800
Subject: [PATCH] [TD-6442]<feature>: Support OpenTSDB telnet style data import
 format

---
 src/client/src/tscParseOpenTSDB.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/client/src/tscParseOpenTSDB.c b/src/client/src/tscParseOpenTSDB.c
index 309bbb919d..397b5d3e97 100644
--- a/src/client/src/tscParseOpenTSDB.c
+++ b/src/client/src/tscParseOpenTSDB.c
@@ -58,7 +58,7 @@ static int32_t parseTelnetMetric(TAOS_SML_DATA_POINT *pSml, const char **index,
     cur++;
     len++;
   }
-  if (len == 0) {
+  if (len == 0 || *cur == '\0') {
     tfree(pSml->stableName);
     return TSDB_CODE_TSC_LINE_SYNTAX_ERROR;
   }
@@ -92,7 +92,7 @@ static int32_t parseTelnetTimeStamp(TAOS_SML_KV **pTS, int *num_kvs, const char
     len++;
   }
 
-  if (len > 0) {
+  if (len > 0 && *cur != '\0') {
     value = tcalloc(len + 1, 1);
     memcpy(value, start, len);
   } else {
@@ -136,7 +136,7 @@ static int32_t parseTelnetMetricValue(TAOS_SML_KV **pKVs, int *num_kvs, const ch
     len++;
   }
 
-  if (len > 0) {
+  if (len > 0 && *cur != '\0') {
     value = tcalloc(len + 1, 1);
     memcpy(value, start, len);
   } else {
@@ -182,7 +182,7 @@ static int32_t parseTelnetTagKey(TAOS_SML_KV *pKV, const char **index, SHashObj
     cur++;
     len++;
   }
-  if (len == 0) {
+  if (len == 0 || *cur == '\0') {
     return TSDB_CODE_TSC_LINE_SYNTAX_ERROR;
   }
   key[len] = '\0';
@@ -366,6 +366,7 @@ int taos_insert_telnet_lines(TAOS* taos, char* lines[], int numLines) {
 
   if (numLines <= 0 || numLines > 65536) {
     tscError("OTD:0x%"PRIx64" taos_insert_telnet_lines numLines should be between 1 and 65536. numLines: %d", info->id, numLines);
+    tfree(info);
     code = TSDB_CODE_TSC_APP_ERROR;
     return code;
   }
-- 
GitLab