From 19fa36ff9deb939965ee3d091b5549b86262ddea Mon Sep 17 00:00:00 2001 From: Minglei Jin Date: Wed, 23 Feb 2022 18:54:57 +0800 Subject: [PATCH] [TS-1222](taosdump): fix memory invalid write issues --- src/kit/taosdump/taosdump.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/kit/taosdump/taosdump.c b/src/kit/taosdump/taosdump.c index abf9476663..5c66b6af68 100644 --- a/src/kit/taosdump/taosdump.c +++ b/src/kit/taosdump/taosdump.c @@ -2053,15 +2053,14 @@ static int getTableDes( memset(tableDes->cols[i].value, 0, sizeof(tableDes->cols[i].value)); int len = strlen((char *)row[0]); - // FIXME for long value - if (len < (COL_VALUEBUF_LEN - 2)) { + if (len <= COL_VALUEBUF_LEN / 4 - 1) { converStringToReadable( (char *)row[0], length[0], tableDes->cols[i].value, len); } else { - tableDes->cols[i].var_value = calloc(1, len * 2); + tableDes->cols[i].var_value = calloc(1, len * 4 + 1); if (tableDes->cols[i].var_value == NULL) { errorPrint("%s() LN%d, memory alalocation failed!\n", __func__, __LINE__); -- GitLab