From 147a984c17631d29392bb346d4670d7db6ad6d7c Mon Sep 17 00:00:00 2001
From: Shengliang Guan <slguan@taosdata.com>
Date: Thu, 23 Jun 2022 15:11:23 +0800
Subject: [PATCH] feat: make config dnode work

---
 source/common/src/tglobal.c                 | 11 ++++++++---
 source/dnode/mgmt/mgmt_dnode/src/dmHandle.c | 11 +++++++++--
 source/util/src/tlog.c                      |  2 +-
 3 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/source/common/src/tglobal.c b/source/common/src/tglobal.c
index 6cae3a13e6..c05d4cf1be 100644
--- a/source/common/src/tglobal.c
+++ b/source/common/src/tglobal.c
@@ -760,9 +760,14 @@ void taosCleanupCfg() {
 }
 
 void taosCfgDynamicOptions(const char *option, const char *value) {
-  if (strcasecmp(option, "debugFlag") == 0) {
-    int32_t debugFlag = atoi(value);
-    taosSetAllDebugFlag(debugFlag);
+  if (strncasecmp(option, "debugFlag", 9) == 0) {
+    if (value != NULL) {
+      if (strlen(option) > 10) {
+        value = option + 10;
+      }
+    }
+    int32_t flag = atoi(value);
+    taosSetAllDebugFlag(flag);
   }
 
   if (strcasecmp(option, "resetlog") == 0) {
diff --git a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
index 9c8918a445..44b6f0ee85 100644
--- a/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
+++ b/source/dnode/mgmt/mgmt_dnode/src/dmHandle.c
@@ -123,8 +123,15 @@ int32_t dmProcessGrantRsp(SDnodeMgmt *pMgmt, SRpcMsg *pMsg) {
 }
 
 int32_t dmProcessConfigReq(SDnodeMgmt *pMgmt, SRpcMsg *pMsg) {
-  dError("config req is received, but not supported yet");
-  return TSDB_CODE_OPS_NOT_SUPPORT;
+  SDCfgDnodeReq cfgReq = {0};
+  if (tDeserializeSMCfgDnodeReq(pMsg->pCont, pMsg->contLen, &cfgReq) != 0) {
+    terrno = TSDB_CODE_INVALID_MSG;
+    return -1;
+  }
+
+  dInfo("start to config, option:%s, value:%s", cfgReq.config, cfgReq.value);
+  taosCfgDynamicOptions(cfgReq.config, cfgReq.value);
+  return 0;
 }
 
 static void dmGetServerRunStatus(SDnodeMgmt *pMgmt, SServerStatusRsp *pStatus) {
diff --git a/source/util/src/tlog.c b/source/util/src/tlog.c
index 353e94a490..0439ed148b 100644
--- a/source/util/src/tlog.c
+++ b/source/util/src/tlog.c
@@ -743,7 +743,7 @@ cmp_end:
 }
 
 void taosSetAllDebugFlag(int32_t flag) {
-  if (!(flag & DEBUG_TRACE || flag & DEBUG_DEBUG || flag & DEBUG_DUMP)) return;
+  if (flag <= 0) return;
 
   dDebugFlag = flag;
   vDebugFlag = flag;
-- 
GitLab