Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
sxychenjing
engine
提交
af5717eb
E
engine
项目概览
sxychenjing
/
engine
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
E
engine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
af5717eb
编写于
10月 01, 2020
作者:
F
Ferhat
提交者:
GitHub
10月 01, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[web] Fix setPreferredOrientations failure on iOS due to NNBD change. (#21531)
上级
f37a0b12
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
28 addition
and
4 deletion
+28
-4
lib/web_ui/lib/src/engine/dom_renderer.dart
lib/web_ui/lib/src/engine/dom_renderer.dart
+4
-4
lib/web_ui/test/engine/window_test.dart
lib/web_ui/test/engine/window_test.dart
+24
-0
未找到文件。
lib/web_ui/lib/src/engine/dom_renderer.dart
浏览文件 @
af5717eb
...
...
@@ -536,18 +536,18 @@ flt-glass-pane * {
Future
<
bool
>
setPreferredOrientation
(
List
<
dynamic
>?
orientations
)
{
final
html
.
Screen
screen
=
html
.
window
.
screen
!;
if
(!
_unsafeIsNull
(
screen
))
{
final
html
.
ScreenOrientation
screenOrientation
=
screen
.
orientation
!
;
final
html
.
ScreenOrientation
?
screenOrientation
=
screen
.
orientation
;
if
(!
_unsafeIsNull
(
screenOrientation
))
{
if
(
orientations
!.
isEmpty
)
{
screenOrientation
.
unlock
();
screenOrientation
!
.
unlock
();
return
Future
.
value
(
true
);
}
else
{
String
?
lockType
=
_deviceOrientationToLockType
(
orientations
.
first
);
if
(
lockType
!=
null
)
{
final
Completer
<
bool
>
completer
=
Completer
<
bool
>();
try
{
screenOrientation
.
lock
(
lockType
).
then
((
dynamic
_
)
{
screenOrientation
!
.
lock
(
lockType
).
then
((
dynamic
_
)
{
completer
.
complete
(
true
);
}).
catchError
((
dynamic
error
)
{
// On Chrome desktop an error with 'not supported on this device
...
...
lib/web_ui/test/engine/window_test.dart
浏览文件 @
af5717eb
...
...
@@ -4,6 +4,7 @@
// @dart = 2.6
import
'dart:async'
;
import
'dart:js_util'
as
js_util
;
import
'dart:html'
as
html
;
import
'dart:typed_data'
;
...
...
@@ -247,6 +248,29 @@ void testMain() {
expect
(
responded
,
isTrue
);
});
/// Regression test for https://github.com/flutter/flutter/issues/66128.
test
(
'setPreferredOrientation responds even if browser doesn
\'
t support api'
,
()
async
{
final
html
.
Screen
screen
=
html
.
window
.
screen
;
js_util
.
setProperty
(
screen
,
'orientation'
,
null
);
bool
responded
=
false
;
final
Completer
<
void
>
completer
=
Completer
<
void
>();
final
ByteData
inputData
=
JSONMethodCodec
().
encodeMethodCall
(
MethodCall
(
'SystemChrome.setPreferredOrientations'
,
<
dynamic
>[]));
window
.
sendPlatformMessage
(
'flutter/platform'
,
inputData
,
(
outputData
)
{
responded
=
true
;
completer
.
complete
();
},
);
await
completer
.
future
;
expect
(
responded
,
true
);
});
test
(
'Window implements locale, locales, and locale change notifications'
,
()
async
{
// This will count how many times we notified about locale changes.
int
localeChangedCount
=
0
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录