From 94dd7165effc9c19c5356e62af694005f65060e1 Mon Sep 17 00:00:00 2001
From: Mehmet Fidanboylu <mehmetf@users.noreply.github.com>
Date: Wed, 7 Nov 2018 15:29:52 -0800
Subject: [PATCH] Skia Cleanup (#6786)

---
 flow/BUILD.gn                      | 1 -
 lib/ui/BUILD.gn                    | 2 --
 lib/ui/painting/codec.cc           | 2 +-
 shell/common/BUILD.gn              | 1 -
 shell/gpu/BUILD.gn                 | 4 ++--
 shell/platform/android/BUILD.gn    | 1 -
 shell/platform/darwin/ios/BUILD.gn | 1 -
 shell/platform/embedder/BUILD.gn   | 1 -
 third_party/txt/BUILD.gn           | 2 +-
 vulkan/BUILD.gn                    | 2 --
 10 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/flow/BUILD.gn b/flow/BUILD.gn
index 6b5cacb54..5a1f50d2e 100644
--- a/flow/BUILD.gn
+++ b/flow/BUILD.gn
@@ -66,7 +66,6 @@ source_set("flow") {
     "$flutter_root/fml",
     "$flutter_root/synchronization",
     "//third_party/skia",
-    "//third_party/skia:gpu",
   ]
 
   if (is_fuchsia) {
diff --git a/lib/ui/BUILD.gn b/lib/ui/BUILD.gn
index a27321c40..8ecf508e5 100644
--- a/lib/ui/BUILD.gn
+++ b/lib/ui/BUILD.gn
@@ -108,8 +108,6 @@ source_set("ui") {
     "//third_party/dart/runtime/bin:dart_io_api",
     "//third_party/rapidjson",
     "//third_party/skia",
-    "//third_party/skia:effects",
-    "//third_party/skia:gpu",
     "//third_party/tonic",
   ]
   if (is_fuchsia) {
diff --git a/lib/ui/painting/codec.cc b/lib/ui/painting/codec.cc
index ba82f8138..608d332f6 100644
--- a/lib/ui/painting/codec.cc
+++ b/lib/ui/painting/codec.cc
@@ -400,7 +400,7 @@ sk_sp<SkImage> MultiFrameCodec::GetNextFrameImage(
     SkCodec::Options options;
     options.fFrameIndex = nextFrameIndex_;
     const int requiredFrame = frameInfos_[nextFrameIndex_].fRequiredFrame;
-    if (requiredFrame != SkCodec::kNone) {
+    if (requiredFrame != SkCodec::kNoFrame) {
       const SkBitmap* requiredBitmap =
           frameBitmaps_[requiredFrame]->bitmap_.get();
       if (requiredBitmap == nullptr) {
diff --git a/shell/common/BUILD.gn b/shell/common/BUILD.gn
index 012dbccc9..c17dd8b60 100644
--- a/shell/common/BUILD.gn
+++ b/shell/common/BUILD.gn
@@ -102,7 +102,6 @@ source_set("common") {
     "$flutter_root/synchronization",
     "//third_party/dart/runtime:dart_api",
     "//third_party/skia",
-    "//third_party/skia:gpu",
   ]
 
   public_deps = [
diff --git a/shell/gpu/BUILD.gn b/shell/gpu/BUILD.gn
index 9356c86b1..a886b0192 100644
--- a/shell/gpu/BUILD.gn
+++ b/shell/gpu/BUILD.gn
@@ -30,7 +30,7 @@ source_set("gpu_surface_gl") {
     "$gpu_dir/gpu_surface_gl.h",
   ]
 
-  deps = gpu_common_deps + [ "//third_party/skia:gpu" ]
+  deps = gpu_common_deps + [ "//third_party/skia" ]
 }
 
 source_set("gpu_surface_vulkan") {
@@ -40,7 +40,7 @@ source_set("gpu_surface_vulkan") {
   ]
 
   deps = gpu_common_deps + [
-           "//third_party/skia:gpu",
+           "//third_party/skia",
            "$flutter_root/vulkan",
          ]
 }
diff --git a/shell/platform/android/BUILD.gn b/shell/platform/android/BUILD.gn
index eb8bff4cf..aad27b2f9 100644
--- a/shell/platform/android/BUILD.gn
+++ b/shell/platform/android/BUILD.gn
@@ -61,7 +61,6 @@ shared_library("flutter_shell_native") {
     "$flutter_root/runtime",
     "$flutter_root/shell/common",
     "//third_party/skia",
-    "//third_party/skia:gpu",
   ]
   if (flutter_runtime_mode == "debug" ||
       flutter_runtime_mode == "dynamic_profile" ||
diff --git a/shell/platform/darwin/ios/BUILD.gn b/shell/platform/darwin/ios/BUILD.gn
index bca96ae9f..a11cf1cd3 100644
--- a/shell/platform/darwin/ios/BUILD.gn
+++ b/shell/platform/darwin/ios/BUILD.gn
@@ -109,7 +109,6 @@ shared_library("create_flutter_framework_dylib") {
     "$flutter_root/shell/common",
     "$flutter_root/shell/platform/darwin/common",
     "//third_party/skia",
-    "//third_party/skia:gpu",
   ]
   if (flutter_runtime_mode == "debug" ||
       flutter_runtime_mode == "dynamic_profile" ||
diff --git a/shell/platform/embedder/BUILD.gn b/shell/platform/embedder/BUILD.gn
index 9ad60a8f7..1e4142bab 100644
--- a/shell/platform/embedder/BUILD.gn
+++ b/shell/platform/embedder/BUILD.gn
@@ -39,7 +39,6 @@ source_set("embedder") {
     "//third_party/dart/runtime:libdart_jit",
     "//third_party/dart/runtime/bin:dart_io_api",
     "//third_party/skia",
-    "//third_party/skia:gpu",
     "//third_party/tonic",
   ]
 
diff --git a/third_party/txt/BUILD.gn b/third_party/txt/BUILD.gn
index 722a4af4d..a6a4bd82d 100644
--- a/third_party/txt/BUILD.gn
+++ b/third_party/txt/BUILD.gn
@@ -113,7 +113,7 @@ source_set("txt") {
   ]
 
   deps = [
-    "//third_party/skia:effects",
+    "//third_party/skia",
   ]
 
   if (is_mac || is_ios) {
diff --git a/vulkan/BUILD.gn b/vulkan/BUILD.gn
index 5a0ed5361..e5412a643 100644
--- a/vulkan/BUILD.gn
+++ b/vulkan/BUILD.gn
@@ -60,12 +60,10 @@ source_set("vulkan") {
   deps = [
     "$flutter_root/fml",
     "//third_party/skia",
-    "//third_party/skia:gpu",
   ]
 
   public_configs = [
     ":vulkan_config",
     "$flutter_root:config",
-    "//third_party/skia:skia_private",
   ]
 }
-- 
GitLab