From 48be433ce2d00aeee4a47dd1f0771118a869bd7d Mon Sep 17 00:00:00 2001 From: Chris Bracken Date: Thu, 20 Dec 2018 12:25:11 -0800 Subject: [PATCH] [License] Enable prefer_is_empty lint --- tools/licenses/analysis_options.yaml | 1 + tools/licenses/lib/filesystem.dart | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/licenses/analysis_options.yaml b/tools/licenses/analysis_options.yaml index e3f9becba..20c0737b2 100644 --- a/tools/licenses/analysis_options.yaml +++ b/tools/licenses/analysis_options.yaml @@ -55,6 +55,7 @@ linter: - prefer_final_fields - prefer_final_locals - prefer_initializing_formals + - prefer_is_empty - prefer_is_not_empty - prefer_single_quotes - prefer_void_to_null diff --git a/tools/licenses/lib/filesystem.dart b/tools/licenses/lib/filesystem.dart index f2640b4a1..07dfd0a45 100644 --- a/tools/licenses/lib/filesystem.dart +++ b/tools/licenses/lib/filesystem.dart @@ -230,7 +230,7 @@ FileType identifyFile(String name, Reader reader) { return FileType.binary; } bytes ??= reader(); - assert(bytes.length > 0); + assert(bytes.isNotEmpty); if (matchesSignature(bytes, [0x1F, 0x8B])) return FileType.gz; // GZip archive if (matchesSignature(bytes, [0x42, 0x5A])) -- GitLab