From f37e86ff58d7b5a47484e60aded45bf8b98ae918 Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Fri, 25 Apr 2014 15:59:53 +0200 Subject: [PATCH] [mono-api-html] Print string fields with no (or null) value without an NRE. --- mcs/tools/corcompare/mono-api-html/FieldComparer.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/mcs/tools/corcompare/mono-api-html/FieldComparer.cs b/mcs/tools/corcompare/mono-api-html/FieldComparer.cs index 54942b64043..fd21e3fb270 100644 --- a/mcs/tools/corcompare/mono-api-html/FieldComparer.cs +++ b/mcs/tools/corcompare/mono-api-html/FieldComparer.cs @@ -71,8 +71,12 @@ namespace Xamarin.ApiDiff { string ftype = e.GetTypeName ("fieldtype"); sb.Append (ftype).Append (' '); sb.Append (name); - if (ftype == "string") - sb.Append (" = \"").Append (e.Attribute ("value").Value).Append ('"'); + if (ftype == "string" && e.Attribute ("value") != null) { + if (value == null) + sb.Append (" = null"); + else + sb.Append (" = \"").Append (value).Append ('"'); + } sb.Append (';'); } -- GitLab