From e55ec66bbc8c40e137b0c845c97a324783cde967 Mon Sep 17 00:00:00 2001 From: Alex Thibodeau Date: Wed, 23 Sep 2020 09:50:19 -0400 Subject: [PATCH] Remove hack from mono_free_method. Bypassing cleanup here was causing corruption to persist in mscorlib's method hashtable when a rehash occurred. Unity profiler may need changes to avoid possessing dangling pointers. Same with the mono profiler (as the comment indicates) --- mono/metadata/loader.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mono/metadata/loader.c b/mono/metadata/loader.c index 8c7a8b7b923..3b4f31f6beb 100644 --- a/mono/metadata/loader.c +++ b/mono/metadata/loader.c @@ -1976,10 +1976,6 @@ mono_free_method (MonoMethod *method) { MONO_PROFILER_RAISE (method_free, (method)); - /* FIXME: This hack will go away when the profiler will support freeing methods */ - if (G_UNLIKELY (mono_profiler_installed ())) - return; - if (method->signature) { /* * FIXME: This causes crashes because the types inside signatures and -- GitLab