From 9dc98f3ff74d71a4edd4f965a702eaed75db6589 Mon Sep 17 00:00:00 2001 From: Jackson Kearl Date: Thu, 21 Jun 2018 17:01:37 -0700 Subject: [PATCH] Add "Click to view details" on extension list items' aria-labels (#51805) * Add "Click to view details" on extension list items' aria-labels * Reword message --- .../extensions/electron-browser/extensionsList.ts | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts index 5b83054fba5..d4240826851 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts @@ -5,6 +5,7 @@ 'use strict'; +import { localize } from 'vs/nls'; import { append, $, addClass, removeClass, toggleClass } from 'vs/base/browser/dom'; import { IDisposable, dispose } from 'vs/base/common/lifecycle'; import { Action } from 'vs/base/common/actions'; @@ -189,16 +190,20 @@ export class Renderer implements IPagedRenderer { private updateRecommendationStatus(extension: IExtension, data: ITemplateData) { const extRecommendations = this.extensionTipsService.getAllRecommendationsWithReason(); + let ariaLabel = extension.displayName + '. '; if (!extRecommendations[extension.id.toLowerCase()]) { - data.root.setAttribute('aria-label', extension.displayName); - data.root.title = ''; removeClass(data.root, 'recommended'); + data.root.title = ''; } else { - data.root.setAttribute('aria-label', extension.displayName + '. ' + extRecommendations[extension.id]); - data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText; addClass(data.root, 'recommended'); + ariaLabel += extRecommendations[extension.id.toLowerCase()].reasonText + ' '; + data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText; } + + ariaLabel += localize('viewExtensionDetailsAria', "Press enter for extension details."); + data.root.setAttribute('aria-label', ariaLabel); + } disposeTemplate(data: ITemplateData): void { -- GitLab