From 7d842fa5d3c7907e331bff2cae9d04112f6f2ca6 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 17 Jul 2019 18:29:19 -0700 Subject: [PATCH] Make sure we update our stored html when using the update function too --- src/vs/workbench/contrib/webview/browser/webviewService.ts | 5 +++-- src/vs/workbench/contrib/webview/common/webview.ts | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/contrib/webview/browser/webviewService.ts b/src/vs/workbench/contrib/webview/browser/webviewService.ts index 344331a4898..18857b50296 100644 --- a/src/vs/workbench/contrib/webview/browser/webviewService.ts +++ b/src/vs/workbench/contrib/webview/browser/webviewService.ts @@ -179,10 +179,11 @@ class DynamicWebviewEditorOverlay extends Disposable implements WebviewEditorOve } } - update(value: string, options: WebviewContentOptions, retainContextWhenHidden: boolean): void { + update(html: string, options: WebviewContentOptions, retainContextWhenHidden: boolean): void { this._contentOptions = options; + this._html = html; this.withWebview(webview => { - webview.update(value, options, retainContextWhenHidden); + webview.update(html, options, retainContextWhenHidden); }); } diff --git a/src/vs/workbench/contrib/webview/common/webview.ts b/src/vs/workbench/contrib/webview/common/webview.ts index c96522f5fab..5f2d3053ff1 100644 --- a/src/vs/workbench/contrib/webview/common/webview.ts +++ b/src/vs/workbench/contrib/webview/common/webview.ts @@ -74,7 +74,7 @@ export interface Webview extends IDisposable { sendMessage(data: any): void; update( - value: string, + html: string, options: WebviewContentOptions, retainContextWhenHidden: boolean ): void; -- GitLab