提交 6ccb91b9 编写于 作者: B Benjamin Pasero

debt - avoid some StrictNullOverride

上级 8985ff7c
......@@ -86,7 +86,7 @@ export interface IIPCOptions {
export class Client implements IChannelClient, IDisposable {
private disposeDelayer: Delayer<void>;
private disposeDelayer: Delayer<void> | undefined;
private activeRequests = new Set<IDisposable>();
private child: ChildProcess | null;
private _client: IPCClient | null;
......@@ -137,7 +137,7 @@ export class Client implements IChannelClient, IDisposable {
cancellationTokenListener.dispose();
this.activeRequests.delete(disposable);
if (this.activeRequests.size === 0) {
if (this.activeRequests.size === 0 && this.disposeDelayer) {
this.disposeDelayer.trigger(() => this.disposeClient());
}
});
......@@ -271,8 +271,10 @@ export class Client implements IChannelClient, IDisposable {
dispose() {
this._onDidProcessExit.dispose();
this.disposeDelayer.cancel();
this.disposeDelayer = null!; // StrictNullOverride: nulling out ok in dispose
if (this.disposeDelayer) {
this.disposeDelayer.cancel();
this.disposeDelayer = undefined;
}
this.disposeClient();
this.activeRequests.clear();
}
......
......@@ -134,7 +134,7 @@ export class OutOfProcessWin32FolderWatcher {
public dispose(): void {
if (this.handle) {
this.handle.kill();
this.handle = null!; // StrictNullOverride: nulling out ok in dispose
this.handle = undefined;
}
}
}
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册