提交 67d8eeba 编写于 作者: M Matt Bierner

Rename webview.show to webview.reveal

Make it more clear that this command only reveals an existing webview

Fixes #44580
上级 683f8604
...@@ -189,8 +189,8 @@ export class MarkdownPreview { ...@@ -189,8 +189,8 @@ export class MarkdownPreview {
return this.matchesResource(otherPreview._resource, otherPreview.viewColumn, otherPreview.locked); return this.matchesResource(otherPreview._resource, otherPreview.viewColumn, otherPreview.locked);
} }
public show(viewColumn: vscode.ViewColumn) { public reveal(viewColumn: vscode.ViewColumn) {
this.webview.show(viewColumn); this.webview.reveal(viewColumn);
} }
public toggleLock() { public toggleLock() {
......
...@@ -63,7 +63,7 @@ export class MarkdownPreviewManager { ...@@ -63,7 +63,7 @@ export class MarkdownPreviewManager {
): void { ): void {
let preview = this.getExistingPreview(resource, previewSettings); let preview = this.getExistingPreview(resource, previewSettings);
if (preview) { if (preview) {
preview.show(previewSettings.previewColumn); preview.reveal(previewSettings.previewColumn);
} else { } else {
preview = this.createNewPreview(resource, previewSettings); preview = this.createNewPreview(resource, previewSettings);
this.previews.push(preview); this.previews.push(preview);
......
...@@ -634,10 +634,10 @@ declare module 'vscode' { ...@@ -634,10 +634,10 @@ declare module 'vscode' {
/** /**
* Shows the webview in a given column. * Shows the webview in a given column.
* *
* A webview may only show in a single column at a time. If it is already showing, this * A webview may only be in a single column at a time. If it is already showing, this
* command moves it to a new column. * command moves it to a new column.
*/ */
show(viewColumn: ViewColumn): void; reveal(viewColumn: ViewColumn): void;
/** /**
* Dispose of the the webview. * Dispose of the the webview.
......
...@@ -87,7 +87,7 @@ export class MainThreadWebviews implements MainThreadWebviewsShape { ...@@ -87,7 +87,7 @@ export class MainThreadWebviews implements MainThreadWebviewsShape {
webview.setHtml(value); webview.setHtml(value);
} }
$show(handle: WebviewHandle, column: Position): void { $reveal(handle: WebviewHandle, column: Position): void {
const webviewInput = this.getWebview(handle); const webviewInput = this.getWebview(handle);
if (webviewInput.position === column) { if (webviewInput.position === column) {
this._editorService.openEditor(webviewInput, { preserveFocus: true }, column); this._editorService.openEditor(webviewInput, { preserveFocus: true }, column);
......
...@@ -352,7 +352,7 @@ export type WebviewHandle = number; ...@@ -352,7 +352,7 @@ export type WebviewHandle = number;
export interface MainThreadWebviewsShape extends IDisposable { export interface MainThreadWebviewsShape extends IDisposable {
$createWebview(handle: WebviewHandle, viewType: string, title: string, column: EditorPosition, options: vscode.WebviewOptions, extensionFolderPath: string): void; $createWebview(handle: WebviewHandle, viewType: string, title: string, column: EditorPosition, options: vscode.WebviewOptions, extensionFolderPath: string): void;
$disposeWebview(handle: WebviewHandle): void; $disposeWebview(handle: WebviewHandle): void;
$show(handle: WebviewHandle, column: EditorPosition): void; $reveal(handle: WebviewHandle, column: EditorPosition): void;
$setTitle(handle: WebviewHandle, value: string): void; $setTitle(handle: WebviewHandle, value: string): void;
$setHtml(handle: WebviewHandle, value: string): void; $setHtml(handle: WebviewHandle, value: string): void;
$sendMessage(handle: WebviewHandle, value: any): Thenable<boolean>; $sendMessage(handle: WebviewHandle, value: any): Thenable<boolean>;
......
...@@ -115,9 +115,9 @@ export class ExtHostWebview implements vscode.Webview { ...@@ -115,9 +115,9 @@ export class ExtHostWebview implements vscode.Webview {
return this._proxy.$sendMessage(this._handle, message); return this._proxy.$sendMessage(this._handle, message);
} }
public show(viewColumn: vscode.ViewColumn): void { public reveal(viewColumn: vscode.ViewColumn): void {
this.assertNotDisposed(); this.assertNotDisposed();
this._proxy.$show(this._handle, typeConverters.fromViewColumn(viewColumn)); this._proxy.$reveal(this._handle, typeConverters.fromViewColumn(viewColumn));
} }
private assertNotDisposed() { private assertNotDisposed() {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册