From 6bcb6e8c19b0720e33e5605ec804bc27ff6a2b65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=90=B4=E6=99=9F=20Wu=20Sheng?= Date: Sun, 18 Oct 2020 19:07:45 +0800 Subject: [PATCH] Fix a comment (#5684) --- .../oap/server/core/analysis/NodeType.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java index 30fe61d97c..80c14a40d1 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/NodeType.java @@ -22,14 +22,13 @@ import org.apache.skywalking.apm.network.language.agent.v3.SpanLayer; import org.apache.skywalking.oap.server.core.UnexpectedException; /** - * Node type describe which kind of node of Service or Network address represents to. - *

- * The value comes from 'org.apache.skywalking.apm.network.language.agent.SpanLayer' at first place, but most likely it - * will extend and be used directly from different sources, such as Mesh. + * Node type describe which kind of node of Service or Network address represents to. The node with {@link #Normal} and + * {@link #Browser} type would be treated as an observed node. */ public enum NodeType { /** - * Unknown = 0; + * Normal = 0; + * This node type would be treated as an observed node. */ Normal(0), /** @@ -54,6 +53,7 @@ public enum NodeType { Cache(5), /** * Browser = 6; + * This node type would be treated as an observed node. */ Browser(6), /** @@ -101,7 +101,7 @@ public enum NodeType { } /** - * Right now, spanLayerValue is exact same as NodeType value. + * @return the node type conjectured from the give span layer. */ public static NodeType fromSpanLayerValue(SpanLayer spanLayer) { switch (spanLayer) { @@ -120,7 +120,7 @@ public enum NodeType { case UNRECOGNIZED: return Unrecognized; default: - throw new UnexpectedException("Unknown NodeType value"); + throw new UnexpectedException("Can't transfer to the NodeType. SpanLayer=" + spanLayer); } } } -- GitLab