From a4ba403e792fc21b5e032ad6116f1fc00fb4ba8d Mon Sep 17 00:00:00 2001 From: Helin Wang Date: Wed, 21 Jun 2017 19:00:25 +0000 Subject: [PATCH] add comment for gracefully stop etcd store --- go/master/etcd_store.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/go/master/etcd_store.go b/go/master/etcd_store.go index ce178370f..d8e95056d 100644 --- a/go/master/etcd_store.go +++ b/go/master/etcd_store.go @@ -29,6 +29,10 @@ type EtcdStore struct { // NewEtcdStore creates a new EtcdStore. func NewEtcdStore(endpoints []string, lockPath, statePath string, ttlSec int) (*EtcdStore, error) { + // TODO(helin): gracefully shutdown etcd store. Becuase etcd + // store holds a etcd lock, even though the lock will expire + // when the lease timeout, we need to implement graceful + // shutdown to release the lock. cli, err := clientv3.New(clientv3.Config{ Endpoints: endpoints, DialTimeout: dialTimeout, -- GitLab