From 7464bd29e865499972043e634a9f23d71ee38b05 Mon Sep 17 00:00:00 2001
From: Xin Pan <panxin.grad@gmail.com>
Date: Mon, 3 Dec 2018 15:44:20 +0800
Subject: [PATCH] polish

test=develop
---
 python/paddle/fluid/framework.py | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/python/paddle/fluid/framework.py b/python/paddle/fluid/framework.py
index 9d1b86abf..f7c86d19f 100644
--- a/python/paddle/fluid/framework.py
+++ b/python/paddle/fluid/framework.py
@@ -612,6 +612,7 @@ class Operator(core.OpBase):
                     return True
             return False
 
+        self.inputs = []
         if inputs is not None:
             for in_proto in proto.inputs:
                 found = find_name(inputs, in_proto.name)
@@ -638,6 +639,13 @@ class Operator(core.OpBase):
                 else:
                     self.desc.set_input(in_proto.name, [])
 
+            for inp in inputs.values():
+                if isinstance(inp, Variable):
+                    self.inputs.append(inp)
+                elif isinstance(inp, list) or isinstance(inp, tuple):
+                    self.inputs.extend(inp[:])
+
+        self.outputs = []
         if outputs is not None:
             given = set()
             need = set()
@@ -666,20 +674,11 @@ class Operator(core.OpBase):
                     arg.op = self
                 self.desc.set_output(out_proto.name, out_arg_names)
 
-        input_vars = []
-        for inp in inputs.values():
-            if isinstance(inp, Variable):
-                input_vars.append(inp)
-            elif isinstance(inp, list) or isinstance(inp, tuple):
-                input_vars.extend(inp[:])
-        self.inputs = input_vars
-        output_vars = []
-        for out in outputs.values():
-            if isinstance(out, Variable):
-                output_vars.append(out)
-            elif isinstance(out, list) or isinstance(out, tuple):
-                output_vars.extend(out[:])
-        self.outputs = output_vars
+            for out in outputs.values():
+                if isinstance(out, Variable):
+                    self.outputs.append(out)
+                elif isinstance(out, list) or isinstance(out, tuple):
+                    self.outputs.extend(out[:])
 
         if op_attrs is not None:
             if not isinstance(op_attrs, dict):
-- 
GitLab