diff --git a/core/pom.xml b/core/pom.xml index c5809733a5b37af9e9889520a72fb7cfcd738677..2c9905295af45306a31606d86b8a283897bb032e 100644 --- a/core/pom.xml +++ b/core/pom.xml @@ -348,7 +348,6 @@ THE SOFTWARE. org.kohsuke graph-layouter - jdk14 1.0 diff --git a/core/src/main/java/hudson/model/AbstractBuild.java b/core/src/main/java/hudson/model/AbstractBuild.java index 9cd724dcf7c3336265b3c0d75a2426afa4e40d6c..251dc4f8021b1a0d1d880454cded6051007e087c 100644 --- a/core/src/main/java/hudson/model/AbstractBuild.java +++ b/core/src/main/java/hudson/model/AbstractBuild.java @@ -262,7 +262,7 @@ public abstract class AbstractBuild

,R extends Abs listener.getLogger().println(node instanceof Hudson ? Messages.AbstractBuild_BuildingOnMaster() : Messages.AbstractBuild_BuildingRemotely(builtOn)); node.getFileSystemProvisioner().prepareWorkspace(AbstractBuild.this,project.getWorkspace(),listener); - int retryCount = getProject().getRetryCount(); + int retryCount = getProject().getScmCheckoutRetryCount(); listener.error("Retry Count.........."+retryCount); boolean checkoutStatus = true; while (retryCount > 0) { diff --git a/core/src/main/java/hudson/model/AbstractProject.java b/core/src/main/java/hudson/model/AbstractProject.java index 50ad1e5217d7782464960e13c755d5aa3f335009..4a96fd5234a9cee7b2dad8c499c3eda5d4127aa1 100644 --- a/core/src/main/java/hudson/model/AbstractProject.java +++ b/core/src/main/java/hudson/model/AbstractProject.java @@ -34,9 +34,7 @@ import hudson.model.Cause.RemoteCause; import hudson.model.Descriptor.FormException; import hudson.model.Fingerprint.RangeSet; import hudson.model.RunMap.Constructor; -import hudson.model.listeners.RunListener; import hudson.model.Queue.WaitingItem; -import hudson.remoting.AsyncFutureImpl; import hudson.scm.ChangeLogSet; import hudson.scm.ChangeLogSet.Entry; import hudson.scm.NullSCM; @@ -114,9 +112,9 @@ public abstract class AbstractProject

,R extends A private volatile Integer quietPeriod = null; /** - * The Retry Count. Null to delegate to the system default. + * The retry count. Null to delegate to the system default. */ - private volatile Integer retryCount = null; + private volatile Integer scmCheckoutRetryCount = null; /** * If this project is configured to be only built on a certain label, @@ -309,8 +307,8 @@ public abstract class AbstractProject

,R extends A return quietPeriod!=null ? quietPeriod : Hudson.getInstance().getQuietPeriod(); } - public int getRetryCount() { - return retryCount!=null ? retryCount : Hudson.getInstance().getRetryCount(); + public int getScmCheckoutRetryCount() { + return scmCheckoutRetryCount !=null ? scmCheckoutRetryCount : Hudson.getInstance().getScmCheckoutRetryCount(); } // ugly name because of EL @@ -318,8 +316,8 @@ public abstract class AbstractProject

,R extends A return quietPeriod!=null; } - public boolean getHasCustomRetryCount(){ - return retryCount != null; + public boolean hasCustomScmCheckoutRetryCount(){ + return scmCheckoutRetryCount != null; } public final boolean isBuildable() { @@ -1178,10 +1176,10 @@ public abstract class AbstractProject

,R extends A } else { quietPeriod = null; } - if(req.getParameter("hasCustomRetryCount")!=null) { - retryCount = Integer.parseInt(req.getParameter("retry_count")); + if(req.getParameter("hasCustomScmCheckoutRetryCount")!=null) { + scmCheckoutRetryCount = Integer.parseInt(req.getParameter("scmCheckoutRetryCount")); } else { - retryCount = null; + scmCheckoutRetryCount = null; } if(req.getParameter("hasSlaveAffinity")!=null) { diff --git a/core/src/main/java/hudson/model/Hudson.java b/core/src/main/java/hudson/model/Hudson.java index 5b7d42d291f9844a5b8385ca437312133513a231..9b1a36bee19ef7e2b627701594024213cee0b134 100644 --- a/core/src/main/java/hudson/model/Hudson.java +++ b/core/src/main/java/hudson/model/Hudson.java @@ -78,9 +78,7 @@ import hudson.security.Permission; import hudson.security.PermissionGroup; import hudson.security.SecurityMode; import hudson.security.SecurityRealm; -import hudson.security.csrf.CrumbFilter; import hudson.security.csrf.CrumbIssuer; -import hudson.security.csrf.CrumbIssuerDescriptor; import hudson.slaves.ComputerListener; import hudson.slaves.NodeProperty; import hudson.slaves.NodePropertyDescriptor; @@ -159,11 +157,8 @@ import java.io.InputStream; import java.io.Serializable; import java.io.PrintStream; import java.io.OutputStream; -import java.io.UnsupportedEncodingException; import java.net.URL; import java.security.SecureRandom; -import java.security.MessageDigest; -import java.security.NoSuchAlgorithmException; import java.text.NumberFormat; import java.text.ParseException; import java.text.Collator; @@ -203,7 +198,6 @@ import java.util.logging.Logger; import java.util.regex.Pattern; import java.nio.charset.Charset; import javax.servlet.RequestDispatcher; -import javax.crypto.spec.SecretKeySpec; import javax.crypto.SecretKey; import groovy.lang.GroovyShell; @@ -368,11 +362,9 @@ public final class Hudson extends Node implements ItemGroup, Stapl /*package*/ Integer quietPeriod; /** - * Retry Count. - * - * This is {@link Integer} so that we can initialize it to '5' for upgrading users. + * Global default for {@link AbstractProject#getScmCheckoutRetryCount()} */ - /*package*/ Integer retryCount; + /*package*/ int scmCheckoutRetryCount; /** * {@link View}s. @@ -1459,10 +1451,10 @@ public final class Hudson extends Node implements ItemGroup, Stapl } /** - * Gets the system default Retry Count period. + * Gets the global SCM check out retry count. */ - public int getRetryCount() { - return retryCount !=null ? retryCount : 5; + public int getScmCheckoutRetryCount() { + return scmCheckoutRetryCount; } @@ -2237,7 +2229,7 @@ public final class Hudson extends Node implements ItemGroup, Stapl quietPeriod = Integer.parseInt(req.getParameter("quiet_period")); - retryCount = Integer.parseInt(req.getParameter("retry_count")); + scmCheckoutRetryCount = Integer.parseInt(req.getParameter("retry_count")); systemMessage = Util.nullify(req.getParameter("system_message")); diff --git a/core/src/main/resources/lib/hudson/project/config-retryCount.jelly b/core/src/main/resources/lib/hudson/project/config-retryCount.jelly index f8fee77dd7069921435bb1301dc033a2f5431aa6..6fa29f23fafe367d9a1b42077e0a87acbdcfe2f6 100644 --- a/core/src/main/resources/lib/hudson/project/config-retryCount.jelly +++ b/core/src/main/resources/lib/hudson/project/config-retryCount.jelly @@ -24,12 +24,10 @@ THE SOFTWARE. - - - + + + \ No newline at end of file diff --git a/war/resources/help/project-config/retryCount.html b/war/resources/help/project-config/retryCount.html deleted file mode 100644 index 7b0446d86ba2a7db9d0880bc4e55703bb7d5103c..0000000000000000000000000000000000000000 --- a/war/resources/help/project-config/retryCount.html +++ /dev/null @@ -1,3 +0,0 @@ -

- If a build fail to checkout from the repository , It will retry the specified number of times. -
\ No newline at end of file diff --git a/war/resources/help/project-config/scmCheckoutRetryCount.html b/war/resources/help/project-config/scmCheckoutRetryCount.html new file mode 100644 index 0000000000000000000000000000000000000000..88f581d2b4f042044589098a0740a9ee6eaa389b --- /dev/null +++ b/war/resources/help/project-config/scmCheckoutRetryCount.html @@ -0,0 +1,4 @@ +
+ If a build fails to checkout from the repository, Hudson will retry the specified number of times before + giving up. +
\ No newline at end of file