diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java index 976dcba17de6bde92e827ae19be61c1e7f78d637..d30534ff8498847b28a1face04035ee2a8bdda02 100644 --- a/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java +++ b/client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java @@ -882,24 +882,6 @@ public class MQClientInstance { this.unregisterClient(null, group); } - private void unregisterClientWithLock(final String producerGroup, final String consumerGroup) { - try { - if (this.lockHeartbeat.tryLock(LOCK_TIMEOUT_MILLIS, TimeUnit.MILLISECONDS)) { - try { - this.unregisterClient(producerGroup, consumerGroup); - } catch (Exception e) { - log.error("unregisterClient exception", e); - } finally { - this.lockHeartbeat.unlock(); - } - } else { - log.warn("lock heartBeat, but failed. [{}]", this.clientId); - } - } catch (InterruptedException e) { - log.warn("unregisterClientWithLock exception", e); - } - } - private void unregisterClient(final String producerGroup, final String consumerGroup) { Iterator>> it = this.brokerAddrTable.entrySet().iterator(); while (it.hasNext()) { @@ -927,7 +909,7 @@ public class MQClientInstance { } } - public boolean registerProducer(final String group, final DefaultMQProducerImpl producer) { + public synchronized boolean registerProducer(final String group, final DefaultMQProducerImpl producer) { if (null == group || null == producer) { return false; } @@ -941,9 +923,9 @@ public class MQClientInstance { return true; } - public void unregisterProducer(final String group) { + public synchronized void unregisterProducer(final String group) { this.producerTable.remove(group); - this.unregisterClientWithLock(group, null); + this.unregisterClient(group, null); } public boolean registerAdminExt(final String group, final MQAdminExtInner admin) {