From 69361f60b70436996e3479e2ed4473f4f1ca2af1 Mon Sep 17 00:00:00 2001
From: a2888409 <122274659@qq.com>
Date: Fri, 20 Jan 2017 10:55:48 +0800
Subject: [PATCH] [ROCKETMQ-37] Polish log output information in
 MQClientManager, closes apache/incubator-rocketmq#33, closes
 apache/incubator-rocketmq#26

---
 .../rocketmq/broker/subscription/SubscriptionGroupManager.java | 2 +-
 .../java/org/apache/rocketmq/client/impl/MQClientManager.java  | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java b/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java
index 92dc5e72..bdf2a01e 100644
--- a/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java
+++ b/broker/src/main/java/org/apache/rocketmq/broker/subscription/SubscriptionGroupManager.java
@@ -184,7 +184,7 @@ public class SubscriptionGroupManager extends ConfigManager {
             this.dataVersion.nextVersion();
             this.persist();
         } else {
-            log.warn("delete subscription group failed, subscription group: {} not exist", old);
+            log.warn("delete subscription group failed, subscription groupName: {} not exist", groupName);
         }
     }
 }
diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java
index 6f2c9a38..f596b836 100644
--- a/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java
+++ b/client/src/main/java/org/apache/rocketmq/client/impl/MQClientManager.java
@@ -53,8 +53,9 @@ public class MQClientManager {
             MQClientInstance prev = this.factoryTable.putIfAbsent(clientId, instance);
             if (prev != null) {
                 instance = prev;
+                log.warn("Returned Previous MQClientInstance for clientId:[{}]", clientId);
             } else {
-                log.warn("Previous MQClientInstance has created for clientId:[{}]", clientId);
+                log.info("Created new MQClientInstance for clientId:[{}]", clientId);
             }
         }
 
-- 
GitLab