diff --git a/components/finsh/shell.c b/components/finsh/shell.c
index 7305bb0370b64b611699ff24ec6e1f64dac63da9..6938ed1f24fa4afe9e63163bf7d970910ffd03df 100644
--- a/components/finsh/shell.c
+++ b/components/finsh/shell.c
@@ -145,18 +145,17 @@ void finsh_set_prompt_mode(rt_uint32_t prompt_mode)
 int finsh_getchar(void)
 {
 #ifdef RT_USING_DEVICE
+    char ch = 0;
 #ifdef RT_USING_POSIX
-    int c;
-    if(read(STDIN_FILENO,&c,1)>0)
+    if(read(STDIN_FILENO, &ch, 1) > 0)
     {
-        return c;
+        return ch;
     }
     else
     {
         return -1; /* EOF */
     }
 #else
-    char ch = 0;
     rt_device_t device;
 
     RT_ASSERT(shell != RT_NULL);