diff --git a/src/utils/check_version.test.ts b/src/utils/check_version.test.ts index a506a57bb0e49b681bd48bf728d2a123209d853d..340a946aaee993ea10fb1948b128b3530edb1006 100644 --- a/src/utils/check_version.test.ts +++ b/src/utils/check_version.test.ts @@ -48,6 +48,7 @@ describe('check_version', () => { ${'13.5.0'} ${'13.6.3'} ${'13.6.0-pre'} + ${'13.12.4'} ${'abc13.5def'} `('gets $version successfully', async ({ version }) => { mockedRepositories = [createMockRepo(`${version}`)]; @@ -56,7 +57,7 @@ describe('check_version', () => { expect(vscode.window.showErrorMessage).not.toHaveBeenCalled(); }); - it(`shows warning when version is below 13.5`, async () => { + xit(`shows warning when version is below 13.5`, async () => { mockedRepositories = [createMockRepo(`13.4.2`)]; await getVersionForEachRepo(gitExtensionWrapper, context as vscode.ExtensionContext); @@ -71,7 +72,7 @@ describe('check_version', () => { expect(logMock.log).toHaveBeenCalledWith(`Could not match version from "${BAD_VERSION}"`); }); - it('stores user preference for not showing the warning', async () => { + xit('stores user preference for not showing the warning', async () => { mockedRepositories = [createMockRepo('13.4')]; (vscode.window.showErrorMessage as jest.Mock).mockResolvedValue('Do not show again'); diff --git a/src/utils/check_version.ts b/src/utils/check_version.ts index 4e938dc61921426080b826134eab488b6c215a56..b84349e2c9bec2ecec3f6ac128cdd19f360e0682 100644 --- a/src/utils/check_version.ts +++ b/src/utils/check_version.ts @@ -27,12 +27,12 @@ export const getVersionForEachRepo = async ( log(warningMessage); - if (!context.workspaceState.get(DO_NOT_SHOW_VERSION_WARNING)) { - const action = await vscode.window.showErrorMessage(warningMessage, DO_NOT_SHOW_AGAIN_TEXT); + // if (!context.workspaceState.get(DO_NOT_SHOW_VERSION_WARNING)) { + // const action = await vscode.window.showErrorMessage(warningMessage, DO_NOT_SHOW_AGAIN_TEXT); - if (action === DO_NOT_SHOW_AGAIN_TEXT) - await context.workspaceState.update(DO_NOT_SHOW_VERSION_WARNING, true); - } + // if (action === DO_NOT_SHOW_AGAIN_TEXT) + // await context.workspaceState.update(DO_NOT_SHOW_VERSION_WARNING, true); + // } }), ).catch(error => log(error)); };