提交 fa38e92c 编写于 作者: J Jan Kara 提交者: Mark Fasheh

ocfs2: Fix check of return value of ocfs2_start_trans()

On failure, ocfs2_start_trans() returns values like ERR_PTR(-ENOMEM).
Thus checks for !handle are wrong. Fix them to use IS_ERR().
Signed-off-by: NJan Kara <jack@suse.cz>
Signed-off-by: NJoel Becker <joel.becker@oracle.com>
Signed-off-by: NMark Fasheh <mfasheh@suse.com>
上级 8573f79d
...@@ -247,8 +247,8 @@ int ocfs2_update_inode_atime(struct inode *inode, ...@@ -247,8 +247,8 @@ int ocfs2_update_inode_atime(struct inode *inode,
mlog_entry_void(); mlog_entry_void();
handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
if (handle == NULL) { if (IS_ERR(handle)) {
ret = -ENOMEM; ret = PTR_ERR(handle);
mlog_errno(ret); mlog_errno(ret);
goto out; goto out;
} }
...@@ -312,8 +312,8 @@ static int ocfs2_simple_size_update(struct inode *inode, ...@@ -312,8 +312,8 @@ static int ocfs2_simple_size_update(struct inode *inode,
handle_t *handle = NULL; handle_t *handle = NULL;
handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
if (handle == NULL) { if (IS_ERR(handle)) {
ret = -ENOMEM; ret = PTR_ERR(handle);
mlog_errno(ret); mlog_errno(ret);
goto out; goto out;
} }
...@@ -1055,8 +1055,8 @@ static int __ocfs2_write_remove_suid(struct inode *inode, ...@@ -1055,8 +1055,8 @@ static int __ocfs2_write_remove_suid(struct inode *inode,
(unsigned long long)OCFS2_I(inode)->ip_blkno, inode->i_mode); (unsigned long long)OCFS2_I(inode)->ip_blkno, inode->i_mode);
handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
if (handle == NULL) { if (IS_ERR(handle)) {
ret = -ENOMEM; ret = PTR_ERR(handle);
mlog_errno(ret); mlog_errno(ret);
goto out; goto out;
} }
...@@ -1259,8 +1259,8 @@ static int __ocfs2_remove_inode_range(struct inode *inode, ...@@ -1259,8 +1259,8 @@ static int __ocfs2_remove_inode_range(struct inode *inode,
} }
handle = ocfs2_start_trans(osb, OCFS2_REMOVE_EXTENT_CREDITS); handle = ocfs2_start_trans(osb, OCFS2_REMOVE_EXTENT_CREDITS);
if (handle == NULL) { if (IS_ERR(handle)) {
ret = -ENOMEM; ret = PTR_ERR(handle);
mlog_errno(ret); mlog_errno(ret);
goto out; goto out;
} }
...@@ -1352,8 +1352,8 @@ static int ocfs2_zero_partial_clusters(struct inode *inode, ...@@ -1352,8 +1352,8 @@ static int ocfs2_zero_partial_clusters(struct inode *inode,
goto out; goto out;
handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS); handle = ocfs2_start_trans(osb, OCFS2_INODE_UPDATE_CREDITS);
if (handle == NULL) { if (IS_ERR(handle)) {
ret = -ENOMEM; ret = PTR_ERR(handle);
mlog_errno(ret); mlog_errno(ret);
goto out; goto out;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册