提交 e842b068 编写于 作者: D Dan Carpenter 提交者: David S. Miller

qlcnic: dcb: a couple off by one bugs

The ->tc_cfg[] array has QLC_DCB_MAX_TC (8) elements so the check is
off by one.  These functions are always called with valid values though
so it doesn't affect how the code works.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Acked-by: NSucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 c84a5711
...@@ -807,7 +807,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, int tc, u8 *prio, ...@@ -807,7 +807,7 @@ qlcnic_dcb_get_pg_tc_cfg_tx(struct net_device *netdev, int tc, u8 *prio,
!type->tc_param_valid) !type->tc_param_valid)
return; return;
if (tc < 0 || (tc > QLC_DCB_MAX_TC)) if (tc < 0 || (tc >= QLC_DCB_MAX_TC))
return; return;
tc_cfg = &type->tc_cfg[tc]; tc_cfg = &type->tc_cfg[tc];
...@@ -843,7 +843,7 @@ static void qlcnic_dcb_get_pg_bwg_cfg_tx(struct net_device *netdev, int pgid, ...@@ -843,7 +843,7 @@ static void qlcnic_dcb_get_pg_bwg_cfg_tx(struct net_device *netdev, int pgid,
!type->tc_param_valid) !type->tc_param_valid)
return; return;
if (pgid < 0 || pgid > QLC_DCB_MAX_PG) if (pgid < 0 || pgid >= QLC_DCB_MAX_PG)
return; return;
pgcfg = &type->pg_cfg[pgid]; pgcfg = &type->pg_cfg[pgid];
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册