提交 41f2c6e8 编写于 作者: A Alessio Igor Bogani 提交者: Greg Kroah-Hartman

USB: sisusbvga: Remove the BKL from ioctl

Seems to me that BKL is not needed here because necessary locking is already
provided by mutex sisusb->lock.

Also change the returned value to long.
Signed-off-by: NAlessio Igor Bogani <abogani@texware.it>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
上级 d20db4b4
......@@ -2974,13 +2974,12 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
struct sisusb_usb_data *sisusb;
struct sisusb_info x;
struct sisusb_command y;
int retval = 0;
long retval = 0;
u32 __user *argp = (u32 __user *)arg;
if (!(sisusb = (struct sisusb_usb_data *)file->private_data))
return -ENODEV;
lock_kernel();
mutex_lock(&sisusb->lock);
/* Sanity check */
......@@ -3039,7 +3038,6 @@ sisusb_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
err_out:
mutex_unlock(&sisusb->lock);
unlock_kernel();
return retval;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册