Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
编程小吉
jenkins
提交
d98716df
J
jenkins
项目概览
编程小吉
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d98716df
编写于
3月 08, 2013
作者:
J
Jesse Glick
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[FIXED JENKINS-17138] Deleting/renaming jobs using external builds directory does not move builds.
上级
b90b2022
变更
3
显示空白变更内容
内联
并排
Showing
3 changed file
with
35 addition
and
0 deletion
+35
-0
changelog.html
changelog.html
+3
-0
core/src/main/java/hudson/model/Job.java
core/src/main/java/hudson/model/Job.java
+12
-0
test/src/test/java/hudson/model/AbstractProjectTest.java
test/src/test/java/hudson/model/AbstractProjectTest.java
+20
-0
未找到文件。
changelog.html
浏览文件 @
d98716df
...
...
@@ -67,6 +67,9 @@ Upcoming changes</a>
<li
class=
bug
>
Permalinks created in the wrong place when using external build directories.
(
<a
href=
"https://issues.jenkins-ci.org/browse/JENKINS-17137"
>
issue 17137
</a>
)
<li
class=
bug
>
External build directories not updated by job rename/delete.
(
<a
href=
"https://issues.jenkins-ci.org/browse/JENKINS-17138"
>
issue 17138
</a>
)
<li
class=
bug
>
JNA-related error from Windows slave monitoring thrown repeatedly.
(
<a
href=
"https://issues.jenkins-ci.org/browse/JENKINS-15796"
>
issue 15796
</a>
)
...
...
core/src/main/java/hudson/model/Job.java
浏览文件 @
d98716df
...
...
@@ -573,7 +573,19 @@ public abstract class Job<JobT extends Job<JobT, RunT>, RunT extends Run<JobT, R
*/
@Override
public
void
renameTo
(
String
newName
)
throws
IOException
{
File
oldBuildDir
=
getBuildDir
();
super
.
renameTo
(
newName
);
File
newBuildDir
=
getBuildDir
();
if
(
oldBuildDir
.
isDirectory
()
&&
!
newBuildDir
.
isDirectory
())
{
if
(!
oldBuildDir
.
renameTo
(
newBuildDir
))
{
throw
new
IOException
(
"failed to rename "
+
oldBuildDir
+
" to "
+
newBuildDir
);
}
}
}
@Override
public
synchronized
void
delete
()
throws
IOException
,
InterruptedException
{
super
.
delete
();
Util
.
deleteRecursive
(
getBuildDir
());
}
/**
...
...
test/src/test/java/hudson/model/AbstractProjectTest.java
浏览文件 @
d98716df
...
...
@@ -354,4 +354,24 @@ public class AbstractProjectTest extends HudsonTestCase {
assertFalse
(
link
.
exists
());
}
@Bug
(
17138
)
public
void
testExternalBuildDirectoryRenameDelete
()
throws
Exception
{
HtmlForm
form
=
new
WebClient
().
goTo
(
"configure"
).
getFormByName
(
"config"
);
File
builds
=
createTmpDir
();
form
.
getInputByName
(
"_.rawBuildsDir"
).
setValueAttribute
(
builds
+
"/${ITEM_FULL_NAME}"
);
submit
(
form
);
assertEquals
(
builds
+
"/${ITEM_FULL_NAME}"
,
jenkins
.
getRawBuildsDir
());
FreeStyleProject
p
=
jenkins
.
createProject
(
MockFolder
.
class
,
"d"
).
createProject
(
FreeStyleProject
.
class
,
"prj"
);
FreeStyleBuild
b
=
p
.
scheduleBuild2
(
0
).
get
();
File
oldBuildDir
=
new
File
(
builds
,
"d/prj"
);
assertEquals
(
new
File
(
oldBuildDir
,
b
.
getId
()),
b
.
getRootDir
());
assertTrue
(
b
.
getRootDir
().
isDirectory
());
p
.
renameTo
(
"proj"
);
File
newBuildDir
=
new
File
(
builds
,
"d/proj"
);
assertEquals
(
new
File
(
newBuildDir
,
b
.
getId
()),
b
.
getRootDir
());
assertTrue
(
b
.
getRootDir
().
isDirectory
());
p
.
delete
();
assertFalse
(
b
.
getRootDir
().
isDirectory
());
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录