From af32c2a16a6e6a619e703b8756c35e2e34fed5f4 Mon Sep 17 00:00:00 2001 From: Tristan Valcke Date: Tue, 15 Nov 2016 18:21:15 +0100 Subject: [PATCH] Remove unnecessary comma, and assign to "undefined" undefined variable in WebGLDeferredRenderer --- examples/js/renderers/WebGLDeferredRenderer.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/examples/js/renderers/WebGLDeferredRenderer.js b/examples/js/renderers/WebGLDeferredRenderer.js index 749c9b9d40..7193684313 100644 --- a/examples/js/renderers/WebGLDeferredRenderer.js +++ b/examples/js/renderers/WebGLDeferredRenderer.js @@ -69,8 +69,8 @@ THREE.WebGLDeferredRenderer = function ( parameters ) { // external properties - this.renderer; - this.domElement; + this.renderer = undefined; + this.domElement = undefined; this.forwardRendering = false; // for debug @@ -1474,7 +1474,7 @@ THREE.DeferredShaderChunk = { "vec4 packedNormalDepth;", "packedNormalDepth.xyz = normal * 0.5 + 0.5;", - "packedNormalDepth.w = position.z / position.w;", + "packedNormalDepth.w = position.z / position.w;" ].join( "\n" ), @@ -1528,7 +1528,7 @@ THREE.DeferredShaderChunk = { "vec3 diffuseColor = float_to_vec3( colorMap.x );", "vec3 emissiveColor = float_to_vec3( colorMap.y );", "vec3 specularColor = float_to_vec3( colorMap.z );", - "float shininess = colorMap.w;", + "float shininess = colorMap.w;" ].join( "\n" ), @@ -1536,7 +1536,7 @@ THREE.DeferredShaderChunk = { "vec4 packedLight;", "packedLight.xyz = lightIntensity * lightColor * max( dot( lightVector, normal ), 0.0 ) * attenuation;", - "packedLight.w = lightIntensity * specular * max( dot( lightVector, normal ), 0.0 ) * attenuation;", + "packedLight.w = lightIntensity * specular * max( dot( lightVector, normal ), 0.0 ) * attenuation;" ].join( "\n" ), @@ -1555,7 +1555,7 @@ THREE.DeferredShaderChunk = { "vec3 halfVector = normalize( lightVector - normalize( vertexPositionVS.xyz ) );", "float dotNormalHalf = max( dot( normal, halfVector ), 0.0 );", - "float specular = 0.31830988618 * ( shininess * 0.5 + 1.0 ) * pow( dotNormalHalf, shininess );", + "float specular = 0.31830988618 * ( shininess * 0.5 + 1.0 ) * pow( dotNormalHalf, shininess );" ].join( "\n" ), @@ -1964,7 +1964,7 @@ THREE.ShaderDeferred = { "}" - ].join( '\n' ), + ].join( '\n' ) }, @@ -2250,7 +2250,7 @@ THREE.ShaderDeferred = { "}" - ].join( '\n' ), + ].join( '\n' ) }, @@ -2374,4 +2374,4 @@ THREE.ShaderDeferred = { } -}; \ No newline at end of file +}; -- GitLab