Merge pull request #18164 from Mugen87/dev29

GLTFLoader: Make .computeBounds() more robust.

examples/js/loaders/GLTFLoader.js

@@ -2291,9 +2291,14 @@ THREE.GLTFLoader = ( function () {
 		if ( attributes.POSITION !== undefined ) {
 
 			var accessor = parser.json.accessors[ attributes.POSITION ];
+
 			var min = accessor.min;
 			var max = accessor.max;
 
+			// glTF requires 'min' and 'max', but VRM (which extends glTF) currently ignores that requirement.
+
+			if ( min !== undefined && max !== undefined ) {
+
 				box.set(
 					new THREE.Vector3( min[ 0 ], min[ 1 ], min[ 2 ] ),
 					new THREE.Vector3( max[ 0 ], max[ 1 ], max[ 2 ] ) );
@@ -2304,6 +2309,12 @@ THREE.GLTFLoader = ( function () {
 
 			}
 
+		} else {
+
+			return;
+
+		}
+
 		var targets = primitiveDef.targets;
 
 		if ( targets !== undefined ) {
@@ -2320,6 +2331,10 @@ THREE.GLTFLoader = ( function () {
 					var min = accessor.min;
 					var max = accessor.max;
 
+					// glTF requires 'min' and 'max', but VRM (which extends glTF) currently ignores that requirement.
+
+					if ( min !== undefined && max !== undefined ) {
+
 						// we need to get max of absolute components because target weight is [-1,1]
 						vector.setX( Math.max( Math.abs( min[ 0 ] ), Math.abs( max[ 0 ] ) ) );
 						vector.setY( Math.max( Math.abs( min[ 1 ] ), Math.abs( max[ 1 ] ) ) );
@@ -2333,6 +2348,8 @@ THREE.GLTFLoader = ( function () {
 
 			}
 
+		}
+
 		geometry.boundingBox = box;
 
 		var sphere = new THREE.Sphere();

examples/jsm/loaders/GLTFLoader.js

@@ -2358,9 +2358,14 @@ var GLTFLoader = ( function () {
 		if ( attributes.POSITION !== undefined ) {
 
 			var accessor = parser.json.accessors[ attributes.POSITION ];
+
 			var min = accessor.min;
 			var max = accessor.max;
 
+			// glTF requires 'min' and 'max', but VRM (which extends glTF) currently ignores that requirement.
+
+			if ( min !== undefined && max !== undefined ) {
+
 				box.set(
 					new Vector3( min[ 0 ], min[ 1 ], min[ 2 ] ),
 					new Vector3( max[ 0 ], max[ 1 ], max[ 2 ] ) );
@@ -2371,6 +2376,12 @@ var GLTFLoader = ( function () {
 
 			}
 
+		} else {
+
+			return;
+
+		}
+
 		var targets = primitiveDef.targets;
 
 		if ( targets !== undefined ) {
@@ -2387,6 +2398,10 @@ var GLTFLoader = ( function () {
 					var min = accessor.min;
 					var max = accessor.max;
 
+					// glTF requires 'min' and 'max', but VRM (which extends glTF) currently ignores that requirement.
+
+					if ( min !== undefined && max !== undefined ) {
+
 						// we need to get max of absolute components because target weight is [-1,1]
 						vector.setX( Math.max( Math.abs( min[ 0 ] ), Math.abs( max[ 0 ] ) ) );
 						vector.setY( Math.max( Math.abs( min[ 1 ] ), Math.abs( max[ 1 ] ) ) );
@@ -2400,6 +2415,8 @@ var GLTFLoader = ( function () {
 
 			}
 
+		}
+
 		geometry.boundingBox = box;
 
 		var sphere = new Sphere();