From 58ee2b3060cc7d9d4195ed324fa9030c6970d1d2 Mon Sep 17 00:00:00 2001
From: zz85 <zz85nus+dev@gmail.com>
Date: Fri, 30 Mar 2012 18:57:31 +0800
Subject: [PATCH] Fixed the parameterless .update() in CameraHelper

---
 examples/webgl_geometry_extrude_splines.html | 6 ++++--
 src/extras/helpers/CameraHelper.js           | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/examples/webgl_geometry_extrude_splines.html b/examples/webgl_geometry_extrude_splines.html
index 3f23e11ae8..7611814cf1 100644
--- a/examples/webgl_geometry_extrude_splines.html
+++ b/examples/webgl_geometry_extrude_splines.html
@@ -19,6 +19,7 @@
     <script src="../build/Three.js"></script>
     <script src="../src/extras/core/Curve.js"></script>
     <script src="../src/extras/geometries/TubeGeometry.js"></script>
+    <script src="../src/extras/helpers/CameraHelper.js"></script>
     <script src="js/Stats.js"></script>
 
 
@@ -524,9 +525,10 @@
       addTube();
 
       // Debug point
-      cameraPos = new THREE.Mesh(new THREE.SphereGeometry(20), new THREE.MeshBasicMaterial({
+      cameraPos = new THREE.Mesh(new THREE.SphereGeometry(10), new THREE.MeshBasicMaterial({
             color: 0xdddddd
         }));
+      cameraPos.visible = false;
       parent.add(cameraPos);
 
       cameraHelper.scale.multiplyScalar(0.1);
@@ -669,7 +671,7 @@
 
         splineCamera.matrix.lookAt( splineCamera.position, lookAt, binormal ); //camera.position.clone().addSelf(dir)
         splineCamera.rotation.getRotationFromMatrix( splineCamera.matrix );
-        cameraHelper.update(splineCamera);
+        cameraHelper.update();
         
         // var axis = new THREE.Vector3( 0, 1, 0 ).crossSelf( dir );
         // var radians = Math.acos( new THREE.Vector3( 0, 1, 0 ).dot( dir.clone().normalize() ) );
diff --git a/src/extras/helpers/CameraHelper.js b/src/extras/helpers/CameraHelper.js
index 6e2c22e561..667fcbb605 100644
--- a/src/extras/helpers/CameraHelper.js
+++ b/src/extras/helpers/CameraHelper.js
@@ -104,7 +104,7 @@ THREE.CameraHelper.prototype.constructor = THREE.CameraHelper;
 
 THREE.CameraHelper.prototype.update = function ( camera ) {
 
-	if (camera !== undefined) {
+	if (camera === undefined) {
 		camera = this.camera;
 	}
 
-- 
GitLab