From 58210a17f605e51d47546c6a9107428b9ab44006 Mon Sep 17 00:00:00 2001
From: Julien Dargelos <julien.dargelos@me.com>
Date: Thu, 30 Jan 2020 22:52:49 +0100
Subject: [PATCH] Add generic Renderer to Object3D and use it when extending
 for css renderers

---
 examples/jsm/renderers/CSS2DRenderer.d.ts | 2 +-
 examples/jsm/renderers/CSS3DRenderer.d.ts | 2 +-
 src/core/Object3D.d.ts                    | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/examples/jsm/renderers/CSS2DRenderer.d.ts b/examples/jsm/renderers/CSS2DRenderer.d.ts
index e464fe95d8..0fc0bd4aea 100644
--- a/examples/jsm/renderers/CSS2DRenderer.d.ts
+++ b/examples/jsm/renderers/CSS2DRenderer.d.ts
@@ -4,7 +4,7 @@ import {
 	Camera
 } from '../../../src/Three';
 
-export class CSS2DObject extends Object3D {
+export class CSS2DObject extends Object3D<CSS2DRenderer> {
 
 	constructor( element: HTMLElement );
 	element: HTMLElement;
diff --git a/examples/jsm/renderers/CSS3DRenderer.d.ts b/examples/jsm/renderers/CSS3DRenderer.d.ts
index 5ad6399b51..6592e24d06 100644
--- a/examples/jsm/renderers/CSS3DRenderer.d.ts
+++ b/examples/jsm/renderers/CSS3DRenderer.d.ts
@@ -4,7 +4,7 @@ import {
 	Camera
 } from '../../../src/Three';
 
-export class CSS3DObject extends Object3D {
+export class CSS3DObject extends Object3D<CSS3DRenderer> {
 
 	constructor( element: HTMLElement );
 	element: HTMLElement;
diff --git a/src/core/Object3D.d.ts b/src/core/Object3D.d.ts
index 2429aeb254..a7f449d6dc 100644
--- a/src/core/Object3D.d.ts
+++ b/src/core/Object3D.d.ts
@@ -20,7 +20,7 @@ export let Object3DIdCount: number;
 /**
  * Base class for scene graph objects
  */
-export class Object3D extends EventDispatcher {
+export class Object3D<Renderer = WebGLRenderer> extends EventDispatcher {
 
 	constructor();
 
@@ -154,7 +154,7 @@ export class Object3D extends EventDispatcher {
 	 * Calls before rendering object
 	 */
 	onBeforeRender: (
-		renderer: WebGLRenderer,
+		renderer: Renderer,
 		scene: Scene,
 		camera: Camera,
 		geometry: Geometry | BufferGeometry,
@@ -166,7 +166,7 @@ export class Object3D extends EventDispatcher {
 	 * Calls after rendering object
 	 */
 	onAfterRender: (
-		renderer: WebGLRenderer,
+		renderer: Renderer,
 		scene: Scene,
 		camera: Camera,
 		geometry: Geometry | BufferGeometry,
-- 
GitLab