From 4ab009d88e586a42d750b002d8acd6f7b8accdf4 Mon Sep 17 00:00:00 2001 From: WestLangley Date: Mon, 16 Oct 2017 20:51:00 -0400 Subject: [PATCH] Standardized default values --- docs/api/geometries/CircleGeometry.html | 4 ++-- docs/api/geometries/CylinderGeometry.html | 8 ++++---- docs/api/geometries/RingGeometry.html | 6 +++--- docs/api/geometries/SphereGeometry.html | 4 ++-- docs/api/geometries/TorusGeometry.html | 6 +++--- docs/api/geometries/TorusKnotGeometry.html | 6 +++--- src/geometries/CircleGeometry.js | 2 +- src/geometries/CylinderGeometry.js | 6 +++--- src/geometries/RingGeometry.js | 4 ++-- src/geometries/SphereGeometry.js | 2 +- src/geometries/TorusGeometry.js | 4 ++-- src/geometries/TorusKnotGeometry.js | 4 ++-- 12 files changed, 28 insertions(+), 28 deletions(-) diff --git a/docs/api/geometries/CircleGeometry.html b/docs/api/geometries/CircleGeometry.html index 8d85299f18..d61019d9dc 100644 --- a/docs/api/geometries/CircleGeometry.html +++ b/docs/api/geometries/CircleGeometry.html @@ -1,7 +1,7 @@ - + @@ -46,7 +46,7 @@

[name]([page:Float radius], [page:Integer segments], [page:Float thetaStart], [page:Float thetaLength])

- radius — Radius of the circle, default = 50.
+ radius — Radius of the circle, default = 1.
segments — Number of segments (triangles), minimum = 3, default = 8.
thetaStart — Start angle for first segment, default = 0 (three o'clock position).
thetaLength — The central angle, often called theta, of the circular sector. The default is 2*Pi, which makes for a complete circle. diff --git a/docs/api/geometries/CylinderGeometry.html b/docs/api/geometries/CylinderGeometry.html index cbe8bb45df..42022a5ace 100644 --- a/docs/api/geometries/CylinderGeometry.html +++ b/docs/api/geometries/CylinderGeometry.html @@ -1,7 +1,7 @@ - + @@ -44,9 +44,9 @@

[name]([page:Float radiusTop], [page:Float radiusBottom], [page:Float height], [page:Integer radiusSegments], [page:Integer heightSegments], [page:Boolean openEnded], [page:Float thetaStart], [page:Float thetaLength])

- radiusTop — Radius of the cylinder at the top. Default is 20.
- radiusBottom — Radius of the cylinder at the bottom. Default is 20.
- height — Height of the cylinder. Default is 100.
+ radiusTop — Radius of the cylinder at the top. Default is 1.
+ radiusBottom — Radius of the cylinder at the bottom. Default is 1.
+ height — Height of the cylinder. Default is 1.
radiusSegments — Number of segmented faces around the circumference of the cylinder. Default is 8
heightSegments — Number of rows of faces along the height of the cylinder. Default is 1.
openEnded — A Boolean indicating whether the ends of the cylinder are open or capped. Default is false, meaning capped.
diff --git a/docs/api/geometries/RingGeometry.html b/docs/api/geometries/RingGeometry.html index de992cd450..88be0601b4 100644 --- a/docs/api/geometries/RingGeometry.html +++ b/docs/api/geometries/RingGeometry.html @@ -1,7 +1,7 @@ - + @@ -44,8 +44,8 @@

[name]([page:Float innerRadius], [page:Float outerRadius], [page:Integer thetaSegments], [page:Integer phiSegments], [page:Float thetaStart], [page:Float thetaLength])

- innerRadius — Default is 20.
- outerRadius — Default is 50.
+ innerRadius — Default is 0.5.
+ outerRadius — Default is 1.
thetaSegments — Number of segments. A higher number means the ring will be more round. Minimum is 3. Default is 8.
phiSegments — Minimum is 1. Default is 8.
thetaStart — Starting angle. Default is 0.
diff --git a/docs/api/geometries/SphereGeometry.html b/docs/api/geometries/SphereGeometry.html index fadf874ada..f28422ba3a 100644 --- a/docs/api/geometries/SphereGeometry.html +++ b/docs/api/geometries/SphereGeometry.html @@ -1,7 +1,7 @@ - + @@ -45,7 +45,7 @@

[name]([page:Float radius], [page:Integer widthSegments], [page:Integer heightSegments], [page:Float phiStart], [page:Float phiLength], [page:Float thetaStart], [page:Float thetaLength])

- radius — sphere radius. Default is 50.
+ radius — sphere radius. Default is 1.
widthSegments — number of horizontal segments. Minimum value is 3, and the default is 8.
heightSegments — number of vertical segments. Minimum value is 2, and the default is 6.
phiStart — specify horizontal starting angle. Default is 0.
diff --git a/docs/api/geometries/TorusGeometry.html b/docs/api/geometries/TorusGeometry.html index 12d5885316..8d8a5ad9d5 100644 --- a/docs/api/geometries/TorusGeometry.html +++ b/docs/api/geometries/TorusGeometry.html @@ -1,7 +1,7 @@ - + @@ -44,8 +44,8 @@

[name]([page:Float radius], [page:Float tube], [page:Integer radialSegments], [page:Integer tubularSegments], [page:Float arc])

- radius — Default is 100.
- tube — Diameter of the tube. Default is 40.
+ radius — Default is 1.
+ tube — Diameter of the tube. Default is 0.4.
radialSegments — Default is 8
tubularSegments — Default is 6.
arc — Central angle. Default is Math.PI * 2. diff --git a/docs/api/geometries/TorusKnotGeometry.html b/docs/api/geometries/TorusKnotGeometry.html index a7e55d786d..e28c4d10a6 100644 --- a/docs/api/geometries/TorusKnotGeometry.html +++ b/docs/api/geometries/TorusKnotGeometry.html @@ -1,7 +1,7 @@ - + @@ -45,8 +45,8 @@

[name]([page:Float radius], [page:Float tube], [page:Integer tubularSegments], [page:Integer radialSegments], [page:Integer p], [page:Integer q])

    -
  • radius — Default is 100.
    • -
  • tube — Diameter of the tube. Default is 40.
    • +
  • radius — Default is 1.
    • +
  • tube — Diameter of the tube. Default is 0.4.
  • tubularSegments — Default is 64.
  • radialSegments — Default is 8.
  • p — This value determines, how many times the geometry winds around its axis of rotational symmetry. Default is 2.
    • diff --git a/src/geometries/CircleGeometry.js b/src/geometries/CircleGeometry.js index 8452640761..20904b9fbf 100644 --- a/src/geometries/CircleGeometry.js +++ b/src/geometries/CircleGeometry.js @@ -48,7 +48,7 @@ function CircleBufferGeometry( radius, segments, thetaStart, thetaLength ) { thetaLength: thetaLength }; - radius = radius || 50; + radius = radius || 1; segments = segments !== undefined ? Math.max( 3, segments ) : 8; thetaStart = thetaStart !== undefined ? thetaStart : 0; diff --git a/src/geometries/CylinderGeometry.js b/src/geometries/CylinderGeometry.js index 129ceb57ae..570623ad77 100644 --- a/src/geometries/CylinderGeometry.js +++ b/src/geometries/CylinderGeometry.js @@ -57,9 +57,9 @@ function CylinderBufferGeometry( radiusTop, radiusBottom, height, radialSegments var scope = this; - radiusTop = radiusTop !== undefined ? radiusTop : 20; - radiusBottom = radiusBottom !== undefined ? radiusBottom : 20; - height = height !== undefined ? height : 100; + radiusTop = radiusTop !== undefined ? radiusTop : 1; + radiusBottom = radiusBottom !== undefined ? radiusBottom : 1; + height = height || 1; radialSegments = Math.floor( radialSegments ) || 8; heightSegments = Math.floor( heightSegments ) || 1; diff --git a/src/geometries/RingGeometry.js b/src/geometries/RingGeometry.js index 21ccfabf86..8acbda18d3 100644 --- a/src/geometries/RingGeometry.js +++ b/src/geometries/RingGeometry.js @@ -51,8 +51,8 @@ function RingBufferGeometry( innerRadius, outerRadius, thetaSegments, phiSegment thetaLength: thetaLength }; - innerRadius = innerRadius || 20; - outerRadius = outerRadius || 50; + innerRadius = innerRadius || 0.5; + outerRadius = outerRadius || 1; thetaStart = thetaStart !== undefined ? thetaStart : 0; thetaLength = thetaLength !== undefined ? thetaLength : Math.PI * 2; diff --git a/src/geometries/SphereGeometry.js b/src/geometries/SphereGeometry.js index 9dd0a4ffe3..287d12f3bb 100644 --- a/src/geometries/SphereGeometry.js +++ b/src/geometries/SphereGeometry.js @@ -53,7 +53,7 @@ function SphereBufferGeometry( radius, widthSegments, heightSegments, phiStart, thetaLength: thetaLength }; - radius = radius || 50; + radius = radius || 1; widthSegments = Math.max( 3, Math.floor( widthSegments ) || 8 ); heightSegments = Math.max( 2, Math.floor( heightSegments ) || 6 ); diff --git a/src/geometries/TorusGeometry.js b/src/geometries/TorusGeometry.js index a612206583..401d34bb07 100644 --- a/src/geometries/TorusGeometry.js +++ b/src/geometries/TorusGeometry.js @@ -49,8 +49,8 @@ function TorusBufferGeometry( radius, tube, radialSegments, tubularSegments, arc arc: arc }; - radius = radius || 100; - tube = tube || 40; + radius = radius || 1; + tube = tube || 0.4; radialSegments = Math.floor( radialSegments ) || 8; tubularSegments = Math.floor( tubularSegments ) || 6; arc = arc || Math.PI * 2; diff --git a/src/geometries/TorusKnotGeometry.js b/src/geometries/TorusKnotGeometry.js index a5d294c8a8..6041d99942 100644 --- a/src/geometries/TorusKnotGeometry.js +++ b/src/geometries/TorusKnotGeometry.js @@ -54,8 +54,8 @@ function TorusKnotBufferGeometry( radius, tube, tubularSegments, radialSegments, q: q }; - radius = radius || 100; - tube = tube || 40; + radius = radius || 1; + tube = tube || 0.4; tubularSegments = Math.floor( tubularSegments ) || 64; radialSegments = Math.floor( radialSegments ) || 8; p = p || 2; -- GitLab