From 17922739aec46499b7abc7a2db7ed0d27e4a12f6 Mon Sep 17 00:00:00 2001 From: satori99 Date: Thu, 6 Nov 2014 16:03:10 +1100 Subject: [PATCH] Only update when state has changed --- examples/js/controls/OrbitControls.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/js/controls/OrbitControls.js b/examples/js/controls/OrbitControls.js index 9faea1f030..b5ab09992e 100644 --- a/examples/js/controls/OrbitControls.js +++ b/examples/js/controls/OrbitControls.js @@ -378,9 +378,11 @@ THREE.OrbitControls = function ( object, domElement ) { } - document.addEventListener( 'mousemove', onMouseMove, false ); - document.addEventListener( 'mouseup', onMouseUp, false ); - scope.dispatchEvent( startEvent ); + if ( state !== STATE.NONE ) { + document.addEventListener( 'mousemove', onMouseMove, false ); + document.addEventListener( 'mouseup', onMouseUp, false ); + scope.dispatchEvent( startEvent ); + } } @@ -439,7 +441,7 @@ THREE.OrbitControls = function ( object, domElement ) { } - scope.update(); + if ( state !== STATE.NONE ) scope.update(); } @@ -456,7 +458,7 @@ THREE.OrbitControls = function ( object, domElement ) { function onMouseWheel( event ) { - if ( scope.enabled === false || scope.noZoom === true ) return; + if ( scope.enabled === false || scope.noZoom === true || state !== STATE.NONE ) return; event.preventDefault(); event.stopPropagation(); @@ -561,7 +563,7 @@ THREE.OrbitControls = function ( object, domElement ) { } - scope.dispatchEvent( startEvent ); + if ( state !== STATE.NONE ) scope.dispatchEvent( startEvent ); } -- GitLab