diff --git a/examples/js/geometries/LightningStrike.js b/examples/js/geometries/LightningStrike.js index 4c08c122527ffc668a6c8566fdd40888d0abf92b..3a05b34013326e4a18d1fa383cd3894e15187cce 100644 --- a/examples/js/geometries/LightningStrike.js +++ b/examples/js/geometries/LightningStrike.js @@ -532,7 +532,7 @@ THREE.LightningStrike.prototype.fillMesh = function ( time ) { }; -THREE.LightningStrike.prototype.addNewSubray = function ( rayParameters ) { +THREE.LightningStrike.prototype.addNewSubray = function ( /*rayParameters*/ ) { return this.subrays[ this.numSubrays ++ ]; @@ -784,7 +784,7 @@ THREE.LightningStrike.prototype.createTriangleVerticesWithUVs = function ( pos, }; -THREE.LightningStrike.prototype.createPrismFaces = function ( vertex, index ) { +THREE.LightningStrike.prototype.createPrismFaces = function ( vertex/*, index*/ ) { var indices = this.indices; var vertex = this.currentVertex - 6; @@ -831,7 +831,7 @@ THREE.LightningStrike.prototype.createDefaultSubrayCreationCallbacks = function var childSubraySeed = random1() * ( currentCycle + 1 ); var isActive = phase % period <= dutyCycle * period; - + var probability = 0; if ( isActive ) { diff --git a/examples/js/utils/SkeletonUtils.js b/examples/js/utils/SkeletonUtils.js index d6503019ec0af3238f5821a16a5f5b034ea9b4b7..671e2a1a1cd344771001ce7663fdacfdd5880135 100644 --- a/examples/js/utils/SkeletonUtils.js +++ b/examples/js/utils/SkeletonUtils.js @@ -2,8 +2,6 @@ * @author sunag / http://www.sunag.com.br */ -'use strict'; - THREE.SkeletonUtils = { retarget: function () { diff --git a/examples/jsm/geometries/LightningStrike.js b/examples/jsm/geometries/LightningStrike.js index 9502cd24a1bce823561cc11c166a63d290ec21d1..0f5e75dd8d651dc43281a8e25564bc260e9a1f93 100644 --- a/examples/jsm/geometries/LightningStrike.js +++ b/examples/jsm/geometries/LightningStrike.js @@ -7,7 +7,7 @@ * Usage * * var myRay = new LightningStrike( paramsObject ); - * var myRayMesh = new Mesh( myRay, myMaterial ); + * var myRayMesh = new THREE.Mesh( myRay, myMaterial ); * scene.add( myRayMesh ); * ... * myRay.update( currentTime ); @@ -105,7 +105,6 @@ import { BufferGeometry, Float32BufferAttribute, Math as _Math, - Mesh, Uint32BufferAttribute, Vector3 } from "../../../build/three.module.js"; @@ -542,7 +541,7 @@ LightningStrike.prototype.fillMesh = function ( time ) { }; -LightningStrike.prototype.addNewSubray = function ( rayParameters ) { +LightningStrike.prototype.addNewSubray = function ( /*rayParameters*/ ) { return this.subrays[ this.numSubrays ++ ]; @@ -794,7 +793,7 @@ LightningStrike.prototype.createTriangleVerticesWithUVs = function ( pos, up, fo }; -LightningStrike.prototype.createPrismFaces = function ( vertex, index ) { +LightningStrike.prototype.createPrismFaces = function ( vertex/*, index*/ ) { var indices = this.indices; var vertex = this.currentVertex - 6; @@ -841,7 +840,7 @@ LightningStrike.prototype.createDefaultSubrayCreationCallbacks = function () { var childSubraySeed = random1() * ( currentCycle + 1 ); var isActive = phase % period <= dutyCycle * period; - + var probability = 0; if ( isActive ) { diff --git a/examples/jsm/objects/LightningStorm.js b/examples/jsm/objects/LightningStorm.js index 0266918aee41043ec28198bb5a48e5d0f70d69e7..217ddd4fc47a97a3f2a48d5f9ddcb8238e89d535 100644 --- a/examples/jsm/objects/LightningStorm.js +++ b/examples/jsm/objects/LightningStorm.js @@ -37,7 +37,7 @@ * * @param {Object} lightningParameters The parameters for created rays. See LightningStrike (geometry) * - * @param {Material} lightningMaterial The Material used for the created rays. + * @param {Material} lightningMaterial The THREE.Material used for the created rays. * * @param {function} onRayPosition Optional callback with two Vector3 parameters (source, dest). You can set here the start and end points for each created ray, using the standard size, minHeight, etc parameters and other values in your algorithm. * @@ -47,7 +47,6 @@ */ import { - Material, Math as _Math, Mesh, MeshBasicMaterial, diff --git a/examples/jsm/utils/SkeletonUtils.js b/examples/jsm/utils/SkeletonUtils.js index 2cb03b3c8928053c9159468a5a970adf96b9c248..bf975b29558bcc708493dfeb42b5bc93909abc40 100644 --- a/examples/jsm/utils/SkeletonUtils.js +++ b/examples/jsm/utils/SkeletonUtils.js @@ -15,8 +15,6 @@ import { VectorKeyframeTrack } from "../../../build/three.module.js"; -'use strict'; - var SkeletonUtils = { retarget: function () { diff --git a/examples/webgl_animation_multiple.html b/examples/webgl_animation_multiple.html index 15184b5901f6395d10492fe6de5b44c35fa96c98..1e2f424385a4ea4fe8528f0bf9bcd1dde21a1cce 100644 --- a/examples/webgl_animation_multiple.html +++ b/examples/webgl_animation_multiple.html @@ -156,13 +156,9 @@ var mixer = startAnimation( clonedMesh, model.animations, u.animationName ); - if ( mixer ) { - - // Save the animation mixer in the list, will need it in the animation loop - mixers.push( mixer ); - numSuccess ++; - - } + // Save the animation mixer in the list, will need it in the animation loop + mixers.push( mixer ); + numSuccess ++; } @@ -281,7 +277,7 @@ console.log( "Done loading model", model.name ); - onLoaded( model ); + onLoaded(); } ); diff --git a/examples/webgl_helpers.html b/examples/webgl_helpers.html index 59dda00d9b0e6fcc3caa664c960637ef4f8825e2..9dfe9654b3869da650ec72740b2bd43df0380404 100644 --- a/examples/webgl_helpers.html +++ b/examples/webgl_helpers.html @@ -19,7 +19,7 @@ var scene, renderer; var camera, light; - var fnh, vnh; + var vnh; init(); animate(); @@ -126,7 +126,6 @@ light.position.y = Math.cos( time * 1.5 ) * 400; light.position.z = Math.cos( time * 1.3 ) * 300; - if ( fnh ) fnh.update(); if ( vnh ) vnh.update(); renderer.render( scene, camera ); diff --git a/utils/modularize.js b/utils/modularize.js index 55c7a285e2affb22fde9d6b5e6cf6ea0798e159c..18f4a119ae0ee1908c3e7a55f76a8368c72786a0 100644 --- a/utils/modularize.js +++ b/utils/modularize.js @@ -54,7 +54,7 @@ var files = [ { path: 'geometries/BoxLineGeometry.js', dependencies: [], ignoreList: [] }, { path: 'geometries/ConvexGeometry.js', dependencies: [ { name: 'ConvexHull', path: 'math/ConvexHull.js' } ], ignoreList: [] }, { path: 'geometries/DecalGeometry.js', dependencies: [], ignoreList: [] }, - { path: 'geometries/LightningStrike.js', dependencies: [ { name: 'SimplexNoise', path: 'math/SimplexNoise.js' } ], ignoreList: [] }, + { path: 'geometries/LightningStrike.js', dependencies: [ { name: 'SimplexNoise', path: 'math/SimplexNoise.js' } ], ignoreList: [ 'Mesh' ] }, { path: 'geometries/ParametricGeometries.js', dependencies: [], ignoreList: [] }, { path: 'geometries/TeapotBufferGeometry.js', dependencies: [], ignoreList: [] }, @@ -143,7 +143,7 @@ var files = [ { path: 'objects/Fire.js', dependencies: [], ignoreList: [] }, { path: 'objects/Lensflare.js', dependencies: [], ignoreList: [] }, - { path: 'objects/LightningStorm.js', dependencies: [ { name: 'LightningStrike', path: 'geometries/LightningStrike.js' } ], ignoreList: [] }, + { path: 'objects/LightningStorm.js', dependencies: [ { name: 'LightningStrike', path: 'geometries/LightningStrike.js' } ], ignoreList: [ 'Material' ] }, { path: 'objects/MarchingCubes.js', dependencies: [], ignoreList: [] }, { path: 'objects/Reflector.js', dependencies: [], ignoreList: [] }, { path: 'objects/Refractor.js', dependencies: [], ignoreList: [] },