From e78b8cf2225fe419de0ffbe48de544b9cbe429f0 Mon Sep 17 00:00:00 2001 From: "Mr.doob" Date: Thu, 26 Jul 2018 13:06:16 -0700 Subject: [PATCH] Fixed some LGTM alerts. --- examples/canvas_lines_colors.html | 4 ++-- examples/canvas_lines_dashed.html | 2 +- examples/webgl_geometry_colors.html | 16 ++++++++-------- examples/webgl_multiple_canvases_complex.html | 18 ++++++++---------- examples/webgl_multiple_canvases_grid.html | 16 ++++++++-------- examples/webgl_multiple_renderers.html | 12 ++++++------ examples/webgl_multiple_views.html | 16 ++++++++-------- 7 files changed, 41 insertions(+), 43 deletions(-) diff --git a/examples/canvas_lines_colors.html b/examples/canvas_lines_colors.html index 155401d97d..fc1b50934f 100644 --- a/examples/canvas_lines_colors.html +++ b/examples/canvas_lines_colors.html @@ -79,7 +79,7 @@ // 2d lines var vertices = hilbert2D( new THREE.Vector3( 0, 0, 0 ), 400, 4 ); - numVertices = vertices.length; + var numVertices = vertices.length; var geometry2 = new THREE.BufferGeometry(); @@ -108,7 +108,7 @@ // 3d lines var vertices = hilbert3D( new THREE.Vector3( 0, 0, 0 ), 200, 2, 0, 1, 2, 3, 4, 5, 6, 7 ); - numVertices = vertices.length; + var numVertices = vertices.length; var geometry3 = new THREE.BufferGeometry(); diff --git a/examples/canvas_lines_dashed.html b/examples/canvas_lines_dashed.html index 9b68f0e2b3..012079838a 100644 --- a/examples/canvas_lines_dashed.html +++ b/examples/canvas_lines_dashed.html @@ -65,7 +65,7 @@ var spline = new THREE.CatmullRomCurve3( points ); var samples = spline.getPoints( points.length * subdivisions ); - numSamples = samples.length; + var numSamples = samples.length; var geometrySpline = new THREE.BufferGeometry(); diff --git a/examples/webgl_geometry_colors.html b/examples/webgl_geometry_colors.html index dc6114d6af..90cb1771a1 100644 --- a/examples/webgl_geometry_colors.html +++ b/examples/webgl_geometry_colors.html @@ -115,8 +115,8 @@ var count = geometry1.attributes.position.count; geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) ); - geometry2 = geometry1.clone(); - geometry3 = geometry1.clone(); + var geometry2 = geometry1.clone(); + var geometry3 = geometry1.clone(); var color = new THREE.Color(); var positions1 = geometry1.attributes.position; @@ -148,21 +148,21 @@ var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } ); - mesh = new THREE.Mesh( geometry1, material ); - wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry1, material ); + var wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = - 400; mesh.rotation.x = - 1.87; scene.add( mesh ); - mesh = new THREE.Mesh( geometry2, material ); - wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry2, material ); + var wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = 400; scene.add( mesh ); - mesh = new THREE.Mesh( geometry3, material ); - wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry3, material ); + var wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); mesh.add( wireframe ); scene.add( mesh ); diff --git a/examples/webgl_multiple_canvases_complex.html b/examples/webgl_multiple_canvases_complex.html index 1bdb3042c4..75834a0f53 100644 --- a/examples/webgl_multiple_canvases_complex.html +++ b/examples/webgl_multiple_canvases_complex.html @@ -177,8 +177,8 @@ var count = geometry1.attributes.position.count; geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) ); - geometry2 = geometry1.clone(); - geometry3 = geometry1.clone(); + var geometry2 = geometry1.clone(); + var geometry3 = geometry1.clone(); var color = new THREE.Color(); var positions1 = geometry1.attributes.position; @@ -210,23 +210,21 @@ var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } ); - var mesh, wireframe; - - mesh = new THREE.Mesh( geometry1, material ); - wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry1, material ); + var wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = - 400; mesh.rotation.x = - 1.87; scene.add( mesh ); - mesh = new THREE.Mesh( geometry2, material ); - wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry2, material ); + var wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = 400; scene.add( mesh ); - mesh = new THREE.Mesh( geometry3, material ); - wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry3, material ); + var wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); mesh.add( wireframe ); scene.add( mesh ); diff --git a/examples/webgl_multiple_canvases_grid.html b/examples/webgl_multiple_canvases_grid.html index 7c7d36da4c..e0e0b77e22 100644 --- a/examples/webgl_multiple_canvases_grid.html +++ b/examples/webgl_multiple_canvases_grid.html @@ -195,8 +195,8 @@ var count = geometry1.attributes.position.count; geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) ); - geometry2 = geometry1.clone(); - geometry3 = geometry1.clone(); + var geometry2 = geometry1.clone(); + var geometry3 = geometry1.clone(); var color = new THREE.Color(); var positions1 = geometry1.attributes.position; @@ -228,21 +228,21 @@ var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } ); - mesh = new THREE.Mesh( geometry1, material ); - wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry1, material ); + var wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = - 400; mesh.rotation.x = - 1.87; scene.add( mesh ); - mesh = new THREE.Mesh( geometry2, material ); - wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry2, material ); + var wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = 400; scene.add( mesh ); - mesh = new THREE.Mesh( geometry3, material ); - wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry3, material ); + var wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); mesh.add( wireframe ); scene.add( mesh ); diff --git a/examples/webgl_multiple_renderers.html b/examples/webgl_multiple_renderers.html index 08e8c075fc..00f6aa4a17 100644 --- a/examples/webgl_multiple_renderers.html +++ b/examples/webgl_multiple_renderers.html @@ -142,21 +142,21 @@ var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } ); - mesh1 = new THREE.Mesh( geometry1, material ); - wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); + var mesh1 = new THREE.Mesh( geometry1, material ); + var wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); mesh1.add( wireframe ); mesh1.position.x = - 400; mesh1.rotation.x = - 1.87; scene.add( mesh1 ); - mesh2 = new THREE.Mesh( geometry2, material ); - wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); + var mesh2 = new THREE.Mesh( geometry2, material ); + var wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); mesh2.add( wireframe ); mesh2.position.x = 400; scene.add( mesh2 ); - mesh3 = new THREE.Mesh( geometry3, material ); - wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); + var mesh3 = new THREE.Mesh( geometry3, material ); + var wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); mesh3.add( wireframe ); scene.add( mesh3 ); diff --git a/examples/webgl_multiple_views.html b/examples/webgl_multiple_views.html index 85bc73d003..3382d869cd 100644 --- a/examples/webgl_multiple_views.html +++ b/examples/webgl_multiple_views.html @@ -166,8 +166,8 @@ var count = geometry1.attributes.position.count; geometry1.addAttribute( 'color', new THREE.BufferAttribute( new Float32Array( count * 3 ), 3 ) ); - geometry2 = geometry1.clone(); - geometry3 = geometry1.clone(); + var geometry2 = geometry1.clone(); + var geometry3 = geometry1.clone(); var color = new THREE.Color(); var positions1 = geometry1.attributes.position; @@ -199,21 +199,21 @@ var wireframeMaterial = new THREE.MeshBasicMaterial( { color: 0x000000, wireframe: true, transparent: true } ); - mesh = new THREE.Mesh( geometry1, material ); - wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry1, material ); + var wireframe = new THREE.Mesh( geometry1, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = - 400; mesh.rotation.x = - 1.87; scene.add( mesh ); - mesh = new THREE.Mesh( geometry2, material ); - wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry2, material ); + var wireframe = new THREE.Mesh( geometry2, wireframeMaterial ); mesh.add( wireframe ); mesh.position.x = 400; scene.add( mesh ); - mesh = new THREE.Mesh( geometry3, material ); - wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); + var mesh = new THREE.Mesh( geometry3, material ); + var wireframe = new THREE.Mesh( geometry3, wireframeMaterial ); mesh.add( wireframe ); scene.add( mesh ); -- GitLab