From 89fdbd0dd351fe4a529194b0c6ce1d2cf47649e2 Mon Sep 17 00:00:00 2001 From: tschw Date: Sat, 11 Jul 2015 15:47:15 +0200 Subject: [PATCH] WebGLProgram: Removed redundant lookup. --- src/renderers/webgl/WebGLProgram.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/renderers/webgl/WebGLProgram.js b/src/renderers/webgl/WebGLProgram.js index e862edbaaf..be6aea0c76 100644 --- a/src/renderers/webgl/WebGLProgram.js +++ b/src/renderers/webgl/WebGLProgram.js @@ -436,28 +436,30 @@ THREE.WebGLProgram = ( function () { // set up caching for uniform locations - var getUniforms = function() { return this._cachedUniforms; }; + var _cachedUniforms; + + var getUniforms = function() { return _cachedUniforms; }; this.getUniforms = function() { // fetch, cache, and next time just use a dumb accessor - var uniforms = fetchUniformLocations( gl, program ); - this._cachedUniforms = uniforms; + _cachedUniforms = fetchUniformLocations( gl, program ); this.getUniforms = getUniforms; - return uniforms; + return _cachedUniforms; }; // set up caching for attribute locations - var getAttributes = function() { return this._cachedAttributes; }; + var _cachedAttributes; + + var getAttributes = function() { return _cachedAttributes; }; this.getAttributes = function() { - var attributes = fetchAttributeLocations( gl, program ); - this._cachedAttributes = attributes; + _cachedAttributes = fetchAttributeLocations( gl, program ); this.getAttributes = getAttributes; - return attributes; + return _cachedAttributes; }; -- GitLab