From 34967bbfe6edf902ba06bda7c984d44db10cf20c Mon Sep 17 00:00:00 2001 From: Michael Herzog Date: Wed, 7 Jul 2021 18:26:58 +0200 Subject: [PATCH] EdgesGeometry: Remove rounding from hash computation. (#22099) --- src/geometries/EdgesGeometry.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/geometries/EdgesGeometry.js b/src/geometries/EdgesGeometry.js index fb717a423e..a80a2bebbc 100644 --- a/src/geometries/EdgesGeometry.js +++ b/src/geometries/EdgesGeometry.js @@ -30,8 +30,6 @@ class EdgesGeometry extends BufferGeometry { } - const precisionPoints = 4; - const precision = Math.pow( 10, precisionPoints ); const thresholdDot = Math.cos( MathUtils.DEG2RAD * thresholdAngle ); const indexAttr = geometry.getIndex(); @@ -67,9 +65,9 @@ class EdgesGeometry extends BufferGeometry { _triangle.getNormal( _normal ); // create hashes for the edge from the vertices - hashes[ 0 ] = `${ Math.round( a.x * precision ) },${ Math.round( a.y * precision ) },${ Math.round( a.z * precision ) }`; - hashes[ 1 ] = `${ Math.round( b.x * precision ) },${ Math.round( b.y * precision ) },${ Math.round( b.z * precision ) }`; - hashes[ 2 ] = `${ Math.round( c.x * precision ) },${ Math.round( c.y * precision ) },${ Math.round( c.z * precision ) }`; + hashes[ 0 ] = `${ a.x },${ a.y },${ a.z }`; + hashes[ 1 ] = `${ b.x },${ b.y },${ b.z }`; + hashes[ 2 ] = `${ c.x },${ c.y },${ c.z }`; // skip degenerate triangles if ( hashes[ 0 ] === hashes[ 1 ] || hashes[ 1 ] === hashes[ 2 ] || hashes[ 2 ] === hashes[ 0 ] ) { -- GitLab