From 12a6fb04990d712badf97fb402556b440bc54c25 Mon Sep 17 00:00:00 2001
From: Shengliang Guan <slguan@taosdata.com>
Date: Thu, 3 Dec 2020 22:48:08 +0800
Subject: [PATCH] crash while quit balance module

---
 src/balance/src/bnThread.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/balance/src/bnThread.c b/src/balance/src/bnThread.c
index a11bc61b01..bf046a9fae 100644
--- a/src/balance/src/bnThread.c
+++ b/src/balance/src/bnThread.c
@@ -36,6 +36,7 @@ static void *bnThreadFunc(void *arg) {
     pthread_mutex_unlock(&(tsBnThread.mutex));
   }
 
+  mDebug("balance thread is stopped");
   return NULL;
 }
 
@@ -47,7 +48,7 @@ int32_t bnInitThread() {
 
   pthread_attr_t thattr;
   pthread_attr_init(&thattr);
-  pthread_attr_setdetachstate(&thattr, PTHREAD_CREATE_DETACHED);
+  pthread_attr_setdetachstate(&thattr, PTHREAD_CREATE_JOINABLE);
   int32_t ret = pthread_create(&tsBnThread.thread, &thattr, bnThreadFunc, NULL);
   pthread_attr_destroy(&thattr);
 
@@ -81,6 +82,8 @@ void bnCleanupThread() {
 }
 
 static void bnPostSignal() {
+  if (tsBnThread.stop) return;
+
   pthread_mutex_lock(&tsBnThread.mutex);
   pthread_cond_signal(&tsBnThread.cond);
   pthread_mutex_unlock(&(tsBnThread.mutex));
-- 
GitLab