From b4d770b813dd1c7cb6a7e2bdf4b8dbb80168a1f7 Mon Sep 17 00:00:00 2001
From: liuqi <liuqi10@xiaomi.com>
Date: Wed, 27 Sep 2017 18:26:19 +0800
Subject: [PATCH] Abort when there are no op registered.

---
 mace/core/net.cc     | 4 +++-
 mace/core/registry.h | 3 +--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/mace/core/net.cc b/mace/core/net.cc
index e6c20cda..d914226e 100644
--- a/mace/core/net.cc
+++ b/mace/core/net.cc
@@ -23,7 +23,9 @@ SimpleNet::SimpleNet(const std::shared_ptr<const NetDef>& net_def,
     std::unique_ptr<OperatorBase> op{nullptr};
     OperatorDef temp_def(operator_def);
     op = CreateOperator(temp_def, ws, type);
-    operators_.emplace_back(std::move(op));
+    if (!op) {
+      operators_.emplace_back(std::move(op));
+    }
   }
 }
 bool SimpleNet::Run() {
diff --git a/mace/core/registry.h b/mace/core/registry.h
index 08ea209d..1295128c 100644
--- a/mace/core/registry.h
+++ b/mace/core/registry.h
@@ -26,8 +26,7 @@ class Registry {
 
   unique_ptr<ObjectType> Create(const SrcType& key, Args... args) {
     if (registry_.count(key) == 0) {
-      VLOG(2) << "Key not registered: " << key;
-      return nullptr;
+      LOG(FATAL) << "Key not registered: " << key;
     }
     return registry_[key](args...);
   }
-- 
GitLab