From 78bea4fc8a49c2ba2fe13a0398f4fcb2131d4efd Mon Sep 17 00:00:00 2001
From: liuqi <liuqi10@xiaomi.com>
Date: Tue, 20 Mar 2018 21:23:23 +0800
Subject: [PATCH] Check not null for pointer arguments.

---
 mace/benchmark/benchmark_model.cc | 2 ++
 mace/utils/command_line_flags.cc  | 1 +
 2 files changed, 3 insertions(+)

diff --git a/mace/benchmark/benchmark_model.cc b/mace/benchmark/benchmark_model.cc
index bf4119cb..38db846b 100644
--- a/mace/benchmark/benchmark_model.cc
+++ b/mace/benchmark/benchmark_model.cc
@@ -100,6 +100,7 @@ bool RunInference(MaceEngine *engine,
                   std::map<std::string, float*> *output_infos,
                   StatSummarizer *summarizer,
                   int64_t *inference_time_us) {
+  MACE_CHECK_NOTNULL(output_infos);
   RunMetadata run_metadata;
   RunMetadata *run_metadata_ptr = nullptr;
   if (summarizer) {
@@ -144,6 +145,7 @@ bool Run(MaceEngine *engine,
          int64_t sleep_sec,
          int64_t *total_time_us,
          int64_t *actual_num_runs) {
+  MACE_CHECK_NOTNULL(output_infos);
   *total_time_us = 0;
 
   LOG(INFO) << "Running benchmark for max " << num_runs << " iterators, max "
diff --git a/mace/utils/command_line_flags.cc b/mace/utils/command_line_flags.cc
index 38c74bb6..e6b80412 100644
--- a/mace/utils/command_line_flags.cc
+++ b/mace/utils/command_line_flags.cc
@@ -13,6 +13,7 @@ namespace mace {
 namespace utils {
 
 bool StringConsume(const std::string &x, std::string *arg) {
+  MACE_CHECK_NOTNULL(arg);
   if ((arg->size() >= x.size()) &&
       (memcmp(arg->data(), x.data(), x.size()) == 0)) {
     *arg = arg->substr(x.size());
-- 
GitLab