From ebbbaee0c3d69b26405875216dbc5e798adab4ba Mon Sep 17 00:00:00 2001
From: Yu Yang <yuyang18@baidu.com>
Date: Wed, 4 Oct 2017 16:18:46 -0700
Subject: [PATCH] Follow comments

---
 paddle/framework/backward.cc    | 4 ++--
 paddle/framework/op_registry.cc | 6 +++---
 paddle/framework/op_registry.h  | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/paddle/framework/backward.cc b/paddle/framework/backward.cc
index 3d81dadfc4..01ef385fd8 100644
--- a/paddle/framework/backward.cc
+++ b/paddle/framework/backward.cc
@@ -39,9 +39,9 @@ static inline std::unique_ptr<OperatorBase> CreateGradOp(
   std::transform(grad_descs.begin(), grad_descs.end(),
                  std::back_inserter(grad_ops),
                  [](const std::unique_ptr<OpDescBind>& grad_desc) {
-                   return OpRegistry::CreateOp(grad_desc.get());
+                   return OpRegistry::CreateOp(*grad_desc);
                  });
-  PADDLE_ENFORCE_GT(grad_ops.size(), 0);
+  PADDLE_ENFORCE(!grad_ops.empty());
   if (grad_ops.size() == 1) {
     return std::move(grad_ops[0]);
   } else {
diff --git a/paddle/framework/op_registry.cc b/paddle/framework/op_registry.cc
index 4dc83ec8fe..e9d2e55872 100644
--- a/paddle/framework/op_registry.cc
+++ b/paddle/framework/op_registry.cc
@@ -54,9 +54,9 @@ std::unique_ptr<OperatorBase> OpRegistry::CreateOp(const OpDesc& op_desc) {
   return CreateOp(op_desc.type(), inputs, outputs, attrs);
 }
 
-std::unique_ptr<OperatorBase> OpRegistry::CreateOp(OpDescBind* op_desc) {
-  return CreateOp(op_desc->Type(), op_desc->Inputs(), op_desc->Outputs(),
-                  op_desc->GetAttrMap());
+std::unique_ptr<OperatorBase> OpRegistry::CreateOp(const OpDescBind& op_desc) {
+  return CreateOp(op_desc.Type(), op_desc.Inputs(), op_desc.Outputs(),
+                  op_desc.GetAttrMap());
 }
 
 }  // namespace framework
diff --git a/paddle/framework/op_registry.h b/paddle/framework/op_registry.h
index a4f0144ce8..4bf521c48d 100644
--- a/paddle/framework/op_registry.h
+++ b/paddle/framework/op_registry.h
@@ -79,7 +79,7 @@ class OpRegistry {
 
   static std::unique_ptr<OperatorBase> CreateOp(const OpDesc& op_desc);
 
-  static std::unique_ptr<OperatorBase> CreateOp(OpDescBind* op_desc);
+  static std::unique_ptr<OperatorBase> CreateOp(const OpDescBind& op_desc);
 };
 
 template <typename OpType, typename ProtoMakerType, typename GradOpType>
-- 
GitLab