diff --git a/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestBuilderGenerator.java b/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestBuilderGenerator.java index c3e75c45782f8ae7650bd04356d5c798a42bec5d..90696a73ce06c919d7fe70e13e77fa9d7d7d9a81 100644 --- a/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestBuilderGenerator.java +++ b/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/RequestBuilderGenerator.java @@ -306,10 +306,7 @@ final class RequestBuilderGenerator { return !input.type.equals(TypeName.get(Override.class)) // SafeVarargs can only be applied to final methods. GlideRequest is // non-final to allow for mocking. - && !input.type.equals(TypeName.get(SafeVarargs.class)) - // @CheckResult isn't applicable for RequestBuilder because there is no - // autoClone() in RequestBuilder. - && !input.type.equals(CHECK_RESULT_CLASS_NAME); + && !input.type.equals(TypeName.get(SafeVarargs.class)); } }) .toList() diff --git a/library/src/main/java/com/bumptech/glide/RequestBuilder.java b/library/src/main/java/com/bumptech/glide/RequestBuilder.java index 55b044f0a11e6da23547b544c67f378bdca02fdd..6ac3518b6c118dde692b22204911696836fdd61a 100644 --- a/library/src/main/java/com/bumptech/glide/RequestBuilder.java +++ b/library/src/main/java/com/bumptech/glide/RequestBuilder.java @@ -85,6 +85,7 @@ public class RequestBuilder implements Cloneable { * @see RequestOptions#apply(RequestOptions) * @return This request builder. */ + @CheckResult public RequestBuilder apply(@NonNull RequestOptions requestOptions) { Preconditions.checkNotNull(requestOptions); this.requestOptions = getMutableOptions().apply(requestOptions); @@ -105,6 +106,7 @@ public class RequestBuilder implements Cloneable { * * @return This request builder. */ + @CheckResult public RequestBuilder transition( @NonNull TransitionOptions transitionOptions) { this.transitionOptions = Preconditions.checkNotNull(transitionOptions); @@ -120,6 +122,7 @@ public class RequestBuilder implements Cloneable { * @param requestListener The request listener to use. * @return This request builder. */ + @CheckResult @SuppressWarnings("unchecked") public RequestBuilder listener( @Nullable RequestListener requestListener) { @@ -141,6 +144,7 @@ public class RequestBuilder implements Cloneable { * *

Recursive calls to thumbnail are supported.

*/ + @CheckResult @SuppressWarnings("unchecked") public RequestBuilder thumbnail( @Nullable RequestBuilder thumbnailRequest) { @@ -173,6 +177,7 @@ public class RequestBuilder implements Cloneable { * the thumbnail. * @return This request builder. */ + @CheckResult @SuppressWarnings("unchecked") public RequestBuilder thumbnail(float sizeMultiplier) { if (sizeMultiplier < 0f || sizeMultiplier > 1f) { @@ -192,6 +197,7 @@ public class RequestBuilder implements Cloneable { * @param model The model to load data for, or null. * @return This request builder. */ + @CheckResult @SuppressWarnings("unchecked") public RequestBuilder load(@Nullable Object model) { return loadGeneric(model); @@ -222,6 +228,7 @@ public class RequestBuilder implements Cloneable { * @param string A file path, or a uri or url handled by * {@link com.bumptech.glide.load.model.UriLoader}. */ + @CheckResult public RequestBuilder load(@Nullable String string) { return loadGeneric(string); } @@ -244,6 +251,7 @@ public class RequestBuilder implements Cloneable { * @param uri The Uri representing the image. Must be of a type handled by * {@link com.bumptech.glide.load.model.UriLoader}. */ + @CheckResult public RequestBuilder load(@Nullable Uri uri) { return loadGeneric(uri); } @@ -266,6 +274,7 @@ public class RequestBuilder implements Cloneable { * * @param file The File containing the image */ + @CheckResult public RequestBuilder load(@Nullable File file) { return loadGeneric(file); } @@ -289,6 +298,7 @@ public class RequestBuilder implements Cloneable { * @see #load(Integer) * @see com.bumptech.glide.signature.ApplicationVersionSignature */ + @CheckResult public RequestBuilder load(@Nullable Integer resourceId) { return loadGeneric(resourceId).apply(signatureOf(ApplicationVersionSignature.obtain(context))); } @@ -303,6 +313,7 @@ public class RequestBuilder implements Cloneable { * {@link #load(android.net.Uri)} or {@link #load(String)}. */ @Deprecated + @CheckResult public RequestBuilder load(@Nullable URL url) { return loadGeneric(url); } @@ -316,6 +327,7 @@ public class RequestBuilder implements Cloneable { * @param model the data to load. * @see #load(Object) */ + @CheckResult public RequestBuilder load(@Nullable byte[] model) { return loadGeneric(model).apply(signatureOf(new ObjectKey(UUID.randomUUID().toString())) .diskCacheStrategy(DiskCacheStrategy.NONE).skipMemoryCache(true /*skipMemoryCache*/));