From 3c1ebe277614f9e7cb2712892122e74e5e0e2d85 Mon Sep 17 00:00:00 2001 From: Sam Judd Date: Sun, 12 Oct 2014 18:19:19 -0700 Subject: [PATCH] Deprecate #load(URL) Fixes #176. --- .../src/main/java/com/bumptech/glide/RequestManager.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/library/src/main/java/com/bumptech/glide/RequestManager.java b/library/src/main/java/com/bumptech/glide/RequestManager.java index d63947317..65d216c66 100644 --- a/library/src/main/java/com/bumptech/glide/RequestManager.java +++ b/library/src/main/java/com/bumptech/glide/RequestManager.java @@ -394,8 +394,12 @@ public class RequestManager implements LifecycleListener { * * @see #using(StreamModelLoader) * + * @deprecated The {@link java.net.URL} class has + * a number of performance problems and should generally be avoided when + * possible. Prefer {@link #load(android.net.Uri)} or {@link #load(String)}. * @param url The URL representing the image. */ + @Deprecated public DrawableTypeRequest load(URL url) { return loadGeneric(url); } @@ -403,8 +407,6 @@ public class RequestManager implements LifecycleListener { /** * Returns a request builder that uses a {@link StreamByteArrayLoader} to load an image from the given byte array. * - * @deprecated Use {@link #load(byte[])} along with - * {@link com.bumptech.glide.GenericRequestBuilder#signature(com.bumptech.glide.load.Key)}} instead. * *

* Note - This method does not cache results in either the disk cache or the memory cache. @@ -412,6 +414,8 @@ public class RequestManager implements LifecycleListener { * * @see #load(byte[]) * + * @deprecated Use {@link #load(byte[])} along with + * {@link com.bumptech.glide.GenericRequestBuilder#signature(com.bumptech.glide.load.Key)} instead. * @param model The data to load. * @param id A unique id that identifies the image represented by the model suitable for use as a cache key * (url, filepath etc). If there is no suitable id, use {@link #load(byte[])} instead. -- GitLab