From f10b7ed8b057c4b6b47fd065e0bb3c66bc0d81df Mon Sep 17 00:00:00 2001 From: "jielin.xu" Date: Wed, 25 Sep 2019 15:18:23 +0800 Subject: [PATCH] Update CONTRIBUTING.md Former-commit-id: c00ea6cb77a7fa35c2ccc864226af5fbb18a64ea --- cpp/CONTRIBUTING.md | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cpp/CONTRIBUTING.md b/cpp/CONTRIBUTING.md index 3be9b724..0d9e30f6 100644 --- a/cpp/CONTRIBUTING.md +++ b/cpp/CONTRIBUTING.md @@ -36,8 +36,8 @@ The Milvus team members will review your pull requests, and once it is accepted, Before sending your pull requests for review, make sure your changes are consistent with the guidelines and follow the Milvus coding style. -- Include unit tests when you contribute new features, as they help to a) prove that your code works correctly, and b) guard against future breaking changes to lower the maintenance cost. -- Bug fixes also generally require unit tests, because the presence of bugs usually indicates insufficient test coverage. +- Include unit tests when you contribute new features, as they help to prove that your code works correctly, and also guard against future breaking changes to lower the maintenance cost. +- Bug fixes also require unit tests, because the presence of bugs usually indicates insufficient test coverage. - Keep API compatibility in mind when you change code in Milvus. Reviewers of your pull request will comment on any API compatibility issues. - When you contribute a new feature to Milvus, the maintenance burden is (by default) transferred to the Milvus team. This means that the benefit of the contribution must be compared against the cost of maintaining the feature. @@ -49,8 +49,6 @@ Before sending your pull requests for review, make sure your changes are consist ```shell $ ./build.sh -u -or -$ ./build.sh --unittest ``` -- GitLab