From f00ca24f1b5ae4f7a32bfde28aad74a37c817bf4 Mon Sep 17 00:00:00 2001
From: zhiru <zhiru.zhu@zilliz.com>
Date: Wed, 3 Jul 2019 14:25:02 +0800
Subject: [PATCH] Disable cleanup if mode is read only

Former-commit-id: 09655e2bb8a52466c1732c829519742867cf07a3
---
 cpp/CHANGELOG.md             | 1 +
 cpp/src/db/MySQLMetaImpl.cpp | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md
index ac3b2c51..19fbbe9c 100644
--- a/cpp/CHANGELOG.md
+++ b/cpp/CHANGELOG.md
@@ -25,6 +25,7 @@ Please mark all change in change log and use the ticket from JIRA.
 - MS-90 - Fix arch match incorrect on ARM
 - MS-99 - Fix compilation bug
 - MS-110 - Avoid huge file size
+- MS-148 - Disable cleanup if mode is read only
 
 ## Improvement
 - MS-82 - Update server startup welcome message
diff --git a/cpp/src/db/MySQLMetaImpl.cpp b/cpp/src/db/MySQLMetaImpl.cpp
index 92bb1716..20b0cef0 100644
--- a/cpp/src/db/MySQLMetaImpl.cpp
+++ b/cpp/src/db/MySQLMetaImpl.cpp
@@ -162,7 +162,9 @@ namespace meta {
             ENGINE_LOG_DEBUG << "MySQL connection pool: maximum pool size = " << std::to_string(maxPoolSize);
             try {
 
-                CleanUp();
+                if (mode_ != Options::MODE::READ_ONLY) {
+                    CleanUp();
+                }
 
                 {
                     ScopedConnection connectionPtr(*mysql_connection_pool_, safe_grab);
@@ -457,7 +459,7 @@ namespace meta {
             } //Scoped Connection
 
 
-            if (mode_ != Options::MODE::SINGLE) {
+            if (mode_ == Options::MODE::CLUSTER) {
                 DeleteTableFiles(table_id);
             }
 
-- 
GitLab