diff --git a/.clang-tidy b/.clang-tidy index 0ffc8c2daab74c370c98f9c85003da46ac99008d..3839aa94d92ea54db229882ea7473428a3733180 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -20,7 +20,13 @@ Checks: > -*, clang-diagnostic-*, -clang-diagnostic-error, clang-analyzer-*, -clang-analyzer-alpha*, google-*, -google-runtime-references, -google-readability-todo, - modernize-*, -modernize-pass-by-value, -modernize-use-equals-default + modernize-*, -modernize-pass-by-value, -modernize-use-equals-default, + performance-faster-string-find, performance-for-range-copy, + performance-implicit-conversion-in-loop, performance-inefficient-algorithm, + performance-trivially-destructible, performance-inefficient-vector-operation, + performance-move-const-arg, performance-move-constructor-init, + performance-noexcept-move-constructor, performance-no-automatic-move, + performance-type-promotion-in-math-fn # produce HeaderFilterRegex from core/build-support/lint_exclusions.txt with: # echo -n '^?!('; sed -e 's/*/\.*/g' core/build-support/lint_exclusions.txt | tr '\n' '|'; echo ')$' diff --git a/core/src/metrics/SystemInfo.cpp b/core/src/metrics/SystemInfo.cpp index 991f6b5c28d1efc216b90c8a2587e13e5f274a13..c3ce4f06d4c76d27bb5c58d431b68226a4919056 100644 --- a/core/src/metrics/SystemInfo.cpp +++ b/core/src/metrics/SystemInfo.cpp @@ -370,10 +370,10 @@ SystemInfo::Octets() { lastline = line; } std::vector space_position; - size_t space_pos = lastline.find(" "); + size_t space_pos = lastline.find(' '); while (space_pos != std::string::npos) { space_position.push_back(space_pos); - space_pos = lastline.find(" ", space_pos + 1); + space_pos = lastline.find(' ', space_pos + 1); } // InOctets is between 6th and 7th " " and OutOctets is between 7th and 8th " " size_t inoctets_begin = space_position[6] + 1; diff --git a/core/src/server/grpc_impl/GrpcRequestHandler.cpp b/core/src/server/grpc_impl/GrpcRequestHandler.cpp index 1d1d8fd2b7c385d81be4b182542f640fbf72e2bf..b0f87ad059fb1034370a4c09b9d141f8385a7c8b 100644 --- a/core/src/server/grpc_impl/GrpcRequestHandler.cpp +++ b/core/src/server/grpc_impl/GrpcRequestHandler.cpp @@ -1323,7 +1323,7 @@ GrpcRequestHandler::Insert(::grpc::ServerContext* context, const ::milvus::grpc: auto grpc_float_size = request->fields(i).attr_record().float_value_size(); auto grpc_double_size = request->fields(i).attr_record().double_value_size(); const auto& field = request->fields(i); - auto field_name = field.field_name(); + auto& field_name = field.field_name(); std::vector temp_data; if (grpc_int32_size > 0) { diff --git a/core/src/utils/Status.cpp b/core/src/utils/Status.cpp index 2ba0917dca7771807f538af92a644b5726ce4f0a..5cf627ef326d407a8a70cde94079dc29b670e7ba 100644 --- a/core/src/utils/Status.cpp +++ b/core/src/utils/Status.cpp @@ -38,7 +38,7 @@ Status::Status(const Status& s) { CopyFrom(s); } -Status::Status(Status&& s) { +Status::Status(Status&& s) noexcept { MoveFrom(s); } @@ -49,7 +49,7 @@ Status::operator=(const Status& s) { } Status& -Status::operator=(Status&& s) { +Status::operator=(Status&& s) noexcept { MoveFrom(s); return *this; } diff --git a/core/src/utils/Status.h b/core/src/utils/Status.h index a2d7b3d255275029f219befe3f557256cdaceb5c..1a45e7bb730b9b7d076f36103174dffd21ab6dbd 100644 --- a/core/src/utils/Status.h +++ b/core/src/utils/Status.h @@ -36,13 +36,13 @@ class Status { Status(const Status& s); - Status(Status&& s); + Status(Status&& s) noexcept; Status& operator=(const Status& s); Status& - operator=(Status&& s); + operator=(Status&& s) noexcept; static Status OK() {